Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant character #15029

Closed
AghaSaad04 opened this issue Mar 15, 2019 · 3 comments
Closed

Redundant character #15029

AghaSaad04 opened this issue Mar 15, 2019 · 3 comments
Assignees
@ibennetch
Labels
ui Issues relating to the user interface
Milestone
5.0.0

Comments

@AghaSaad04
Copy link
Contributor

Is your feature request related to a problem? Please describe.

There is a redundant character in below image that I have attached. Character basically shows that max limit is 25 but if somebody doesn't hover on that and increases the history length still he'll get the error message that "Value must be equal or lower than 25!". So there's no need of that character.

image

Describe the solution you'd like

Remove that character, as it is redundant. The functionality of that character is already being fulfilled by the error message that appears when somebody exceeds the history length.

Additional context

  • phpMyAdmin version: 4.8.5
@ibennetch ibennetch self-assigned this Mar 15, 2019
@williamdes williamdes added the ui Issues relating to the user interface label Mar 19, 2019
@ibennetch ibennetch removed their assignment Mar 19, 2019
@ibennetch
Copy link
Member

I find this change reasonable. A pull request for it should target master.

@murex971 murex971 mentioned this issue Mar 22, 2019
Merged
ibennetch pushed a commit that referenced this issue Mar 24, 2019
@murex971 @ibennetch
Deleted redundant help/tool tip on page settings (#15061)
b09d956 
Removed redundant help/tool tip in page settings "Query history length" area.

Fixes issue #15029

Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@ibennetch
Copy link
Member

Thanks for reporting, this has been fixed in master and will be part of the 5.0 release.

@ibennetch ibennetch added this to the 5.0.0 milestone Mar 24, 2019
@ibennetch ibennetch self-assigned this Mar 24, 2019
@AghaSaad04
Copy link
Contributor Author

Okay, great Sir @ibennetch 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ibennetch ibennetch

Labels
ui Issues relating to the user interface
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
3 participants
@ibennetch @williamdes @AghaSaad04