Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input fields are missing checks. #15036

Closed
AghaSaad04 opened this issue Mar 16, 2019 · 1 comment
Closed

Input fields are missing checks. #15036

AghaSaad04 opened this issue Mar 16, 2019 · 1 comment
Assignees
@williamdes
Labels
has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone
4.9.0.1

Comments

@AghaSaad04
Copy link
Contributor

Describe the bug

Some input fields are allowing negative numbers. So there should be a check and those fields should not allow negative numbers.

To Reproduce

Steps to reproduce the behavior:

  1. Click on 'settings'
  2. Click on 'features'
  3. Click on 'text fields'
  4. Change the Minimum size for input field to a negative number
  5. Change the Maximum size for input field to a negative number
  6. The input fields wouldn't print any warning or error.

Expected behavior

I was expecting a warning after giving a negative input.

Screenshots

image

Server configuration

  • Operating system: Windows
  • Web server: XAMPP
  • PHP version: 7.3.0
  • phpMyAdmin version: 4.8.5

Client configuration

  • Browser: Firefox
  • Operating system: Windows

Additional context

Add any other context about the problem here.
@williamdes williamdes added the ui Issues relating to the user interface label Mar 16, 2019
@apoorvkhare07
Copy link
Contributor

@williamdes On it.

apoorvkhare07 added a commit to apoorvkhare07/phpmyadmin that referenced this issue Mar 19, 2019
@apoorvkhare07
Fixes phpmyadmin#15036 Input fields missing checks
32b98a7
apoorvkhare07 added a commit to apoorvkhare07/phpmyadmin that referenced this issue Mar 19, 2019
@apoorvkhare07
Fixes phpmyadmin#15036 Input fields missing checks
3656420 
Signed-off-by: apoorv <apoorvkhare007@gmail.com>
@apoorvkhare07 apoorvkhare07 mentioned this issue Mar 20, 2019
Merged
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Mar 20, 2019
@williamdes williamdes self-assigned this Apr 4, 2019
@williamdes williamdes added this to the 4.8.6 milestone Apr 4, 2019
williamdes added a commit that referenced this issue Apr 4, 2019
@williamdes
Fix #15036 - Input fields missing checks for MaxSizeForInputField
cfc75fd 
Fixes: #15036
Pull-request: #15056
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Apr 4, 2019
@williamdes
Add ChangeLog entry for #15036
5413b6c 
Pull-request: #15056
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Milestone
4.9.0.1
Development

No branches or pull requests
3 participants
@williamdes @apoorvkhare07 @AghaSaad04