Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset button on Settings > Features does not reset error messages #15037

Closed
AghaSaad04 opened this issue Mar 16, 2019 · 3 comments
Closed

Reset button on Settings > Features does not reset error messages #15037

AghaSaad04 opened this issue Mar 16, 2019 · 3 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
Milestone
4.9.0.1

Comments

@AghaSaad04
Copy link
Contributor

Describe the bug

I have given some negative number as an input in multiple fields and those fields show warning which says that "Not a positive number". Then I clicked on the reset button those negative values got reset but it is still showing the warnings.

To Reproduce

Steps to reproduce the behavior:

  1. Click on 'settings'
  2. Click on 'features'
  3. Click on 'text fields'
  4. Change the input fields to negative numbers
  5. It'll give warning "Not a positive number"
  6. Click on "reset" button
  7. It'll reset the values but will still show those warnings.

Expected behavior

I was expecting that after clicking the reset button it'd not only reset the values but would also remove those warnings.

Screenshots

before clicking the reset button:

image

after clicking the reset button:

image

Server configuration

  • Operating system: Windows
  • Web server: XAMPP
  • PHP version: 7.3.0
  • phpMyAdmin version: 4.8.5

Client configuration

  • Browser: Firefox
  • Operating system: Windows
@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface good first issue labels Mar 16, 2019
@apoorvkhare07
Copy link
Contributor

@williamdes Hi, I think I have found the solution. Should I make a PR for this ?

@williamdes
Copy link
Member

Hi @apoorvkhare07 , yes please :)

apoorvkhare07 added a commit to apoorvkhare07/phpmyadmin that referenced this issue Mar 17, 2019
@apoorvkhare07
Fixes phpmyadmin#15037 Unexpected behaviour of reset button
e901a3e
apoorvkhare07 added a commit to apoorvkhare07/phpmyadmin that referenced this issue Mar 17, 2019
@apoorvkhare07
Fixes phpmyadmin#15037 Unexpected behaviour of reset button
81643c9 
Signed-off-by: apoorv <apoorvkhare007@gmail.com>
apoorvkhare07 added a commit to apoorvkhare07/phpmyadmin that referenced this issue Mar 17, 2019
@apoorvkhare07
Fixes phpmyadmin#15037 Unexpected behaviour of reset button
723db3f 
Signed-off-by: apoorv <apoorvkhare007@gmail.com>
@apoorvkhare07 apoorvkhare07 mentioned this issue Mar 17, 2019
Merged
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Mar 17, 2019
@williamdes williamdes added this to To be sorted in issues May 2, 2019
@williamdes williamdes self-assigned this May 4, 2019
@williamdes williamdes changed the title Reset button Reset button on Settings > Features does not reset error messages May 4, 2019
@williamdes williamdes moved this from To be sorted to ready to merge in issues May 4, 2019
williamdes added a commit that referenced this issue May 4, 2019
@williamdes
Fix #15037 - Unexpected behavior of reset button
191a81c 
Fixes: #15037
Pull-request: #15045
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue May 4, 2019
@williamdes
Add ChangeLog entry for #15240 #15043 and #15037
14ddb9a 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from ready to merge to Closed May 4, 2019
@williamdes williamdes added this to the 4.8.6 milestone May 4, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
4.9.0.1
Development

No branches or pull requests
3 participants
@williamdes @apoorvkhare07 @AghaSaad04