Console height allows negative number

[AghaSaad04]

Describe the bug

I have given a large negative number as a console height it has not given an error or warning but converted that number to some other number when I clicked the apply button.

To Reproduce

Steps to reproduce the behavior:

1. Go to 'settings'
2. Click on 'features'
3. Click on 'console'
4. Give a negative large number as an input for console height
5. Click on the apply button.
6. You'll see the difference after that.

Expected behavior

I was expecting that there would be some limit or range of the console height and that input field would not allow negative number, as console height cannot be negative.

Screenshots

Before applying:

After applying:

Server configuration

• Operating system: Windows
• Web server: XAMPP
• PHP version: 7.3.0
• phpMyAdmin version: 4.8.5

Client configuration

• Browser: Firefox
• Operating system: Windows

[ibennetch]

We should check lower and upper limits, as mentioned in #15035.

[ibennetch]

Related to: #15035.

[apoorvkhare07]

@ibennetch @williamdes @AghaSaad04 The configuration for validating console height goes like $cfg_db['Console']['Height'] = 'integer'; in config.value.php. Which defines it as a PHP integer value which can have value between -2,147,483,648 to 2,147,483,647 only. This is the reason for this issue as well as #15035 .

In order to fix this we can think of a different way of validating these field. Similar to other fields where we use form ids and field names/ids to define their validation scheme.

[apoorvkhare07]

@williamdes @ibennetch Can you please comment on in what way should I proceed with this ?
Because trying some other way to validate this might be different from the convention used for other fields of same type.
So, please let me know what way is fine for you all.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.