Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple printing + Checks missing #15043

Closed
AghaSaad04 opened this issue Mar 17, 2019 · 3 comments
Closed

Multiple printing + Checks missing #15043

AghaSaad04 opened this issue Mar 17, 2019 · 3 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature ui Issues relating to the user interface
Projects
issues
Milestone
4.9.0.1

Comments

@AghaSaad04
Copy link
Contributor

AghaSaad04 commented Mar 17, 2019 •
edited by williamdes

Describe the bug

I am in settings>navigation panel> navigation panel. Some inputs fields are printing errors multiple times and some input fields are missing checks and don't print any error.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'settings'
  2. Click on 'navigation panel'
  3. Click on 'navigation panel'
  4. Give negative numbers in the input fields
  5. Some will print errors and some will not
  6. If you repeat steps 2 - 4, errors will be printed multiple times

Expected behavior

I was expecting that all the input fields would have some checks at the backend and they would not allow any negative number or alphabets and they wouldn't print errors multiple times.

Screenshots

image

Fixes (maybe): #15043

Server configuration

  • Operating system: Windows
  • Web server: XAMPP
  • PHP version: 7.3.0
  • phpMyAdmin version: 4.8.5

Client configuration

  • Browser: Firefox
  • Operating system: Windows
@apoorvkhare07
Copy link
Contributor

I will like to look into this one.

@williamdes williamdes added the ui Issues relating to the user interface label Mar 19, 2019
@apoorvkhare07
Copy link
Contributor

@williamdes @AghaSaad04 I think Check Missing on some field and multiple printing of errors should be different issues, as both are completely unrelated.

apoorvkhare07 added a commit to apoorvkhare07/phpmyadmin that referenced this issue Mar 19, 2019
@apoorvkhare07
Fix phpmyadmin#15043 Multiple printing + Checks missing
475b9ae 
Signed-off-by: apoorv <apoorvkhare007@gmail.com>
apoorvkhare07 added a commit to apoorvkhare07/phpmyadmin that referenced this issue Mar 19, 2019
@apoorvkhare07
Fix phpmyadmin#15043 Multiple printing + Checks missing
8792380
@apoorvkhare07 apoorvkhare07 mentioned this issue Mar 19, 2019
Merged
6 tasks
@AghaSaad04 AghaSaad04 mentioned this issue Mar 23, 2019
Closed
@williamdes williamdes self-assigned this May 4, 2019
@williamdes williamdes added the Bug A problem or regression with an existing feature label May 4, 2019
@williamdes williamdes added this to Needs triage in issues via automation May 4, 2019
@williamdes williamdes moved this from Needs triage to ready to merge in issues May 4, 2019
williamdes added a commit that referenced this issue May 4, 2019
@williamdes
Fix #15043 - Multiple errors printing on Settings page
8e20d8c 
Fixes: #15043
Pull-request: #15054
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue May 4, 2019
@williamdes
Add ChangeLog entry for #15240 #15043 and #15037
14ddb9a 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from ready to merge to Closed May 4, 2019
@williamdes williamdes added this to the 4.8.6 milestone May 4, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
4.9.0.1
Development

No branches or pull requests
3 participants
@williamdes @apoorvkhare07 @AghaSaad04