Redundant close button

[murex971]

Describe the bug

The cross sign at the right top corner serves the purpose of closing the dialog box. So there is no need of extra 'close' button at the bottom.

To Reproduce

Steps to reproduce the behavior:

1. Go to 'Status'
2. Click on 'advisor'.
3. Click on instructions.

Screenshots

Server configuration

• Operating system: ubuntu 18.04
• Web server: apache
• PHP version: 7.2
• phpMyAdmin version: 5.0.0-dev

Client configuration

• Browser:Firefox, Google Chrome
• Operating system:ubuntu

[AghaSaad04]

I am working on it @murex971.

[apoorvkhare07]

@ibennetch @murex971 I don't think this really is an issue . This is a very common practice to have such UI.

And @AghaSaad04 Even if we decide to remove one of the two, top-right close icon should be removed not the close button as it gives a better experience.

[murex971]

@apoorvkhare07 when we open the instruction dialog box of monitor tab, it shows only cross sign and no close button.
I think the site should follow a common UI.
also the ss which you have attached is regarding confirmation of exit action and there exit button and cross symbol are playing different roles . Ours is a different scenario.

[apoorvkhare07]

@murex971 Ya we should follow a common UI at all places. So we can add a close button in Monitor instruction as well. I mean that thing @ibennetch @williamdes can decide what common UI elements we need to follow.
Also @murex971 in the screenshot I pasted above the close icon and the cancel button are playing pretty similar role.

[MauricioFauth]

I merged #15114, which adds the Close button to the Monitor Instructions modal.

[AghaSaad04]

Okay great @MauricioFauth 👍

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.