Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings export "Save as file" should reference JSON type #15115

Closed
ibennetch opened this issue Mar 27, 2019 · 1 comment
Closed

Settings export "Save as file" should reference JSON type #15115

ibennetch opened this issue Mar 27, 2019 · 1 comment
Assignees
Labels
translation ui Issues relating to the user interface

Comments

@ibennetch
Copy link
Member

In the Settings area, we can "Export as file" but it doesn't specify what type of file that is. I think it should say "Export as JSON file".

This text is used twice, as Export_asfile_name in libraries/classes/Config/Descriptions.php and in prefs_manage.php. We need to verify the use of each of those before making the change.

This probably needs to be a dirty translation change.

@ibennetch ibennetch self-assigned this Mar 27, 2019
@williamdes williamdes added translation ui Issues relating to the user interface labels Mar 27, 2019
@ibennetch
Copy link
Member Author

libraries/classes/Config/Descriptions.php references the settings -> export setting to save the export as a file, so this is fine as-is.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
translation ui Issues relating to the user interface
Projects
None yet
Development

No branches or pull requests

2 participants