Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing an insert, edit link does not work #15140

Closed
williamdes opened this issue Mar 31, 2019 · 4 comments
Closed

Failing an insert, edit link does not work #15140

williamdes opened this issue Mar 31, 2019 · 4 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature
Milestone
4.9.0.1

Comments

@williamdes
Copy link
Member

williamdes commented Mar 31, 2019 •
edited

Describe the bug

Fail an insert, an edit link in sent back in the modal, but it does not work anymore
The query is sent to tbl_sql.php in _GET and is not used to fill the sql query box

To Reproduce

Steps to reproduce the behavior:

  1. Fail an insert
  2. Click on 'edit query'

The query is not filled.

Screenshots

image

Server configuration

  • phpMyAdmin version: 4.8.6-dev
@williamdes williamdes added the Bug A problem or regression with an existing feature label Mar 31, 2019
@saurass
Copy link
Contributor

saurass commented Apr 1, 2019

@williamdes I just checked, in case of failure, the EDIT link redirects to tbl_sql.php and the query box is filled with a query.

using branch QA_4_6

@williamdes
Copy link
Member Author

@saurass Did you check this is the expected query?

Did you want to say QA_4_8?

@saurass
Copy link
Contributor

saurass commented Apr 1, 2019

Seems I went wrong at two points,
the query is NOT visible
using branch QA_4_8

Error reproduced.

Would try to work this out : )

saurass added a commit to saurass/phpmyadmin that referenced this issue Apr 1, 2019
@saurass
Fix - phpmyadmin#15140 -Failing an insert, edit link does not work
a18e4b1 
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
@saurass saurass mentioned this issue Apr 1, 2019
Merged
6 tasks
@saurass
Copy link
Contributor

saurass commented Apr 1, 2019

@williamdes @ibennetch please review this PR : )

williamdes added a commit that referenced this issue Apr 1, 2019
@williamdes
Add ChangeLog entry for #15140 and #14334
fd69070 
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this Apr 1, 2019
@williamdes williamdes added this to the 4.8.6 milestone Apr 1, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature
Projects
None yet
Milestone
4.9.0.1
Development

No branches or pull requests
2 participants
@williamdes @saurass