Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Settings' not marked as active when browsing 2FA settings #15157

Closed
AghaSaad04 opened this issue Apr 5, 2019 · 2 comments
Closed

'Settings' not marked as active when browsing 2FA settings #15157

AghaSaad04 opened this issue Apr 5, 2019 · 2 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
Milestone
4.9.0.1

Comments

@AghaSaad04
Copy link
Contributor

Describe the bug

Whenever I select two-factor authentication its parent that is settings got unselected but for other children, it shows different behavior.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'settings'
  2. Click on two-factor authentication
  3. You'll see that settings gets unselected.

Expected behavior

Settings should not have got unselected

Screenshots

image

Server configuration

  • Operating system: Windows
  • Web server: XAMPP
  • PHP version: 7.3.0
  • phpMyAdmin version: 5.0.0-dev

Client configuration

  • Browser: Firefox, Google Chrome
  • Operating system: Windows
@AghaSaad04
Copy link
Contributor Author

I am working on its solution @williamdes, will create a PR shortly.

@AghaSaad04 AghaSaad04 mentioned this issue Apr 5, 2019
Closed
6 tasks
@williamdes williamdes added Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface labels Apr 6, 2019
@williamdes williamdes added this to To be sorted in issues May 2, 2019
@williamdes williamdes changed the title Submenu is selected but parent menu got unselected 'Settings' not marked as active when browsing 2FA settings May 4, 2019
williamdes added a commit that referenced this issue May 4, 2019
@williamdes
Add ChangeLog entry for #15157
20227b0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from To be sorted to Closed May 4, 2019
@williamdes williamdes self-assigned this May 4, 2019
@williamdes williamdes added this to the 4.8.6 milestone May 4, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
4.9.0.1
Development

Successfully merging a pull request may close this issue.

Fixes #15157 - 'Settings' not marked as active when browsing 2FA settings
2 participants
@williamdes @AghaSaad04