Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Text area overflows its parent element #15161

Closed
AghaSaad04 opened this issue Apr 7, 2019 · 2 comments
Closed

[UI] Text area overflows its parent element #15161

AghaSaad04 opened this issue Apr 7, 2019 · 2 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete newbie ui Issues relating to the user interface
Projects
issues
Milestone
4.9.2

Comments

@AghaSaad04
Copy link
Contributor

Describe the bug

Text Area is overflowing its parent div

To Reproduce

Steps to reproduce the behavior:

  1. Select a DB
  2. Click on 'Query'
  3. Scroll down
  4. See text area overflowing

Expected behavior

It should not overflow its parent

Screenshots

image

Server configuration

  • Operating system: Windows
  • Web server: XAMPP
  • PHP version: 7.3.0
  • phpMyAdmin version: 5.0.0-dev

Client configuration

  • Browser: Firefox
  • Operating system: Windows
@AghaSaad04 AghaSaad04 mentioned this issue Apr 7, 2019
Closed
6 tasks
@williamdes williamdes added Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface labels Apr 7, 2019
@williamdes williamdes added this to To be sorted in issues May 2, 2019
@williamdes williamdes moved this from To be sorted to ready to merge in issues May 3, 2019
@williamdes williamdes added newbie and removed has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels May 28, 2019
@anksh1997
Copy link
Contributor

Hie @williamdes Sir, I am not able to reproduce the bug as it seems fine with me in local as well as remote server :)
Screenshot from 2019-05-30 20-49-37
Uploading Screenshot from 2019-05-30 20-49-14.png…

@falconfx falconfx mentioned this issue Jun 17, 2019
Merged
6 tasks
@falconfx
Copy link
Contributor

falconfx commented Jun 19, 2019 •
edited

I am still trying to validate the PR so that it passes all the tests, but here I have made a possible approach to the solution #15342

Pd: The problem with this is that it will happen in all the views I think

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jun 22, 2019
ecordoba24 pushed a commit to ecordoba24/phpmyadmin that referenced this issue Sep 27, 2019
FIX: [UI] Text area overflows its parent element phpmyadmin#15161
a79c04d
@ecordoba24 ecordoba24 mentioned this issue Sep 27, 2019
Closed
ecordoba24 pushed a commit to ecordoba24/phpmyadmin that referenced this issue Sep 27, 2019
FIX: [UI] Text area overflows its parent element phpmyadmin#15161
55282ff 
Signed-off-by: Eugenio <eugenio@nexorone.com>
ecordoba24 pushed a commit to ecordoba24/phpmyadmin that referenced this issue Sep 27, 2019
@ecordoba24
FIX: [UI] Text area overflows its parent element phpmyadmin#15161
d0ea3b6 
Signed-off-by: Eugenio <e.cordoba.24@gmail.com>
ecordoba24 added a commit to ecordoba24/phpmyadmin that referenced this issue Oct 1, 2019
@ecordoba24
FIX: [UI] Text area overflows its parent element phpmyadmin#15161
55ea65e
ecordoba24 added a commit to ecordoba24/phpmyadmin that referenced this issue Oct 1, 2019
@ecordoba24
FIX: [UI] Text area overflows its parent element phpmyadmin#15161 rev…
b652713 
…ert last commit
williamdes added a commit that referenced this issue Oct 17, 2019
@williamdes
Add ChangeLog entry for #15161
22b0425 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this Oct 17, 2019
@williamdes williamdes added this to the 4.9.2 milestone Oct 17, 2019
issues automation moved this from ready to merge to Closed Oct 17, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete newbie ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
4.9.2
Development

Successfully merging a pull request may close this issue.

Fixes #15161 Text area overflows its parent
4 participants
@williamdes @falconfx @anksh1997 @AghaSaad04