Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

label not aligned with baseline #15177

Closed
murex971 opened this issue Apr 11, 2019 · 6 comments · Fixed by #15178
Closed

label not aligned with baseline #15177

murex971 opened this issue Apr 11, 2019 · 6 comments · Fixed by #15178
Assignees
@MauricioFauth
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone
4.9.0.1

Comments

@murex971
Copy link
Contributor

Describe the bug

label text aligned at the top.

Expected behavior

label text should be properly aligned to baseline.

Screenshots

baseline
@murex971 murex971 mentioned this issue Apr 11, 2019
Merged
6 tasks
@AghaSaad04
Copy link
Contributor

AghaSaad04 commented Apr 11, 2019 •
edited

Current layout:
image

Proposed layout
image

@williamdes What do you think about this one?
Should I move the label near to fields?

@murex971
Copy link
Contributor Author

@AghaSaad04 I've already open a pr referencing the issue in which I've fixed the label text alignment with respect to the input field

@AghaSaad04
Copy link
Contributor

@murex971, you have fixed that but I am not talking about that. I am asking @williamdes for aligning text to center.

Your solution:
image

and the solution I am proposing is different.
image

@AndikanAffiah
Copy link

I think the second is okay

@murex971
Copy link
Contributor Author

@AghaSaad04 IMO aligning text of label at the center alongwith baseline is a good idea.
Thanks for your opinion.
I'm working on another commit to make the changes you have suggested.

@AghaSaad04
Copy link
Contributor

Okay, great @murex971. I was actually about to create the PR.

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Apr 16, 2019
@MauricioFauth MauricioFauth added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Apr 16, 2019
@MauricioFauth MauricioFauth self-assigned this Apr 16, 2019
MauricioFauth added a commit that referenced this issue Apr 16, 2019
@MauricioFauth
Add ChangeLog entry for #15177
97357c3 
[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth added this to the 4.8.6 milestone Apr 16, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MauricioFauth MauricioFauth

Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Milestone
4.9.0.1
Development

Successfully merging a pull request may close this issue.

Fix label alignment on login page murex971/phpmyadmin
5 participants
@MauricioFauth @williamdes @AndikanAffiah @AghaSaad04 @murex971