Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout Issue in Structure #15194

Closed
AghaSaad04 opened this issue Apr 14, 2019 · 11 comments · Fixed by #15870
Closed

Layout Issue in Structure #15194

AghaSaad04 opened this issue Apr 14, 2019 · 11 comments · Fixed by #15870
Assignees
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Milestone

Comments

@AghaSaad04
Copy link
Contributor

AghaSaad04 commented Apr 14, 2019

Describe the bug

Layout issue when horizontally scrolled

To Reproduce

Steps to reproduce the behavior:

  1. Select a DB and a table
  2. Go to Structure
  3. Click on change option for any column
  4. Scroll horizontally
  5. See error

Expected behavior

Buttons should not scroll.

Screenshots

image

Server configuration

  • Operating system: Windows 10
  • Web server: Apache
  • PHP version: 7.3.0
  • phpMyAdmin version: 5.0.0-dev

Client configuration

  • Browser: Firefox 65.0.1 (64-bit)
  • Operating system: Windows 10
@AghaSaad04
Copy link
Contributor Author

Working on it :)

@williamdes williamdes added has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface labels Apr 14, 2019
@lem9
Copy link
Contributor

lem9 commented Apr 18, 2019

To reach your screenshot some steps are missing; I had to reach the page where I can change a column's structure. Are you talking about the "Preview SQL" and "Save" buttons?

@AghaSaad04
Copy link
Contributor Author

Oh yeah, Sorry @lem9. I am going to edit them right now. And I have got the solution for this issue but I am not sure if it's the best solution, I will create the PR for this soon

@AghaSaad04
Copy link
Contributor Author

and yes Sir @lem9. I am talking about those buttons

@williamdes williamdes added this to Triage zone in Enhancements Jan 23, 2020
@williamdes williamdes removed the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 24, 2020
@williamdes williamdes removed this from Triage zone in Enhancements Jan 24, 2020
@williamdes williamdes added this to Needs triage in issues via automation Jan 24, 2020
@williamdes williamdes moved this from Needs triage to n/a priority in issues Jan 24, 2020
@rabeehrz
Copy link
Contributor

@williamdes Is someone working on this? If not, Can I work on this?

@williamdes
Copy link
Member

@rabeehrz You can work on this one if you want

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Jan 28, 2020
@williamdes williamdes self-assigned this Jan 28, 2020
@williamdes williamdes added this to the 5.1.0 milestone Jan 28, 2020
williamdes added a commit that referenced this issue Jan 28, 2020
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from n/a priority to Closed Jan 28, 2020
@NKarasek
Copy link

Quick question - does this issue reference the problem with "column headers not maintaining correct column widths"?

  1. view as query result with more columns than can fit on a single screen (horizontal)- and more rows than can fit on a screen (vertical).
  2. scroll down the initial results page to the point where the original column headers scroll off the top.
  3. the replacement header's content changes (no 'Options') and the browser is asked to develop the width's of each column (specific width set for each ). It does so but the result does not line up the header column titles with the content of the displayed database rows.

It appears that as the page is scrolled, when "table stickey_columns" is activated, the column widths are incorrectly computed - not off by much, but still 'off'. The data underneath "table "stickey_columns" is still available - those columns are still correctly sized - but their width is not being used to define the widths of the column headers. Just wondering - hopefully fixed for release in 5.10.

@williamdes
Copy link
Member

Good question, I am not sure to have the good answer could you try on demo server ? (root, no password) 5.1.0-dev

@NKarasek
Copy link

NKarasek commented Mar 29, 2020 via email

@NKarasek
Copy link

NKarasek commented Mar 29, 2020 via email

@ibennetch
Copy link
Member

@NKarasek I have fixed the demo server (at least, for now), so you can try again if you'd like. I've opened issue #16055 relating to that problem.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Development

Successfully merging a pull request may close this issue.

6 participants