Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating user with single quote in password results in no password user #15202

Closed
Interghost opened this issue Apr 15, 2019 · 7 comments
Closed

Creating user with single quote in password results in no password user #15202

Interghost opened this issue Apr 15, 2019 · 7 comments
Assignees
@ibennetch @williamdes
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
4.9.1

Comments

@Interghost
Copy link

Interghost commented Apr 15, 2019 •
edited

Tried on demo.phpmyadmin 4.8.5 and 4.8.6-dev
Go to User accounts tab, Add user account
Username: test
Password: test'123
And submit/create...afterwards go back to User accounts tab and the new user will be listed as no password.
@williamdes williamdes added Bug A problem or regression with an existing feature good first issue labels Apr 16, 2019
@williamdes
Copy link
Member

@Interghost thank you for the report!

@apoorvkhare07
Copy link
Contributor

@williamdes I would like to work on this one.

@williamdes
Copy link
Member

@apoorvkhare07 You can work on this one :)

@kartik1000
Copy link
Contributor

@apoorvkhare07, Hey a suggestion for this one, you might have to use mysqli_real_escape_string function of php while working with input password field in php, to remove any problem that the quotes might be causing :)

@williamdes williamdes added this to to be fixed soon in issues Apr 29, 2019
@Dec0y-jb
Copy link

Has this been resolved yet? I don't mind submitting a PR for this if one hasn't been already.

@williamdes
Copy link
Member

williamdes commented May 20, 2019 •
edited

@Dec0y-jb Contributions are welcome, no PR has been open to fix this issue
Do not forget to use QA_4_9 as base and QA_4_9 as target
Also, use --signoff on all commits and use your real name for legal reasons :)

@Dec0y-jb
Copy link

@williamdes - Thanks! I will submit this tonight. Seems to be an easy one.

@ibennetch ibennetch self-assigned this Jul 12, 2019
@ibennetch ibennetch added this to the 4.9.1 milestone Jul 12, 2019
@kartik1000 kartik1000 mentioned this issue Aug 11, 2019
Merged
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Aug 11, 2019
@williamdes williamdes self-assigned this Aug 15, 2019
williamdes added a commit that referenced this issue Aug 15, 2019
@williamdes
Fix #15202 - escaped correctly password
6b9ccd6 
Fixes: #15202
Pull-request: #15428

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Aug 15, 2019
@williamdes
Add ChangeLog entry for #15202
27ead96 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Aug 15, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ibennetch ibennetch

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
4.9.1
Development

No branches or pull requests
6 participants
@ibennetch @Interghost @williamdes @apoorvkhare07 @Dec0y-jb @kartik1000