Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Useless backquotes, sql preview, delete index #15205

Closed
williamdes opened this issue Apr 15, 2019 · 3 comments
Closed

[UI] Useless backquotes, sql preview, delete index #15205

williamdes opened this issue Apr 15, 2019 · 3 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Milestone
4.9.0.1

Comments

@williamdes
Copy link
Member

Describe the bug

Useless backquotes in the sql query: around the query and the table name (2 instead of one)

To Reproduce

Steps to reproduce the behavior:

  1. Try to delete an index
  2. See backquotes

Expected behavior

No quotes and a beautiful sql preview box

Screenshots

Screenshot_20190415-221441

Server configuration

  • phpMyAdmin version: 4.8.6
@williamdes williamdes added the Bug A problem or regression with an existing feature label Apr 15, 2019
@williamdes
Copy link
Member Author

@saurass can you please have a look?

@saurass
Copy link
Contributor

saurass commented Apr 15, 2019

Yeah sure, I will look into it ASAP.

saurass added a commit to saurass/phpmyadmin that referenced this issue Apr 16, 2019
@saurass
Fix - phpmyadmin#15205 - Useless backquotes, sql preview, delete index
5d6f761 
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
@saurass saurass mentioned this issue Apr 16, 2019
Merged
6 tasks
@kartik1000 kartik1000 mentioned this issue Apr 25, 2019
Closed
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Apr 25, 2019
@williamdes williamdes self-assigned this Apr 28, 2019
@williamdes williamdes added this to the 4.8.6 milestone Apr 28, 2019
williamdes added a commit that referenced this issue Apr 28, 2019
@williamdes
Add ChangeLog entry for #15205
14e8d5d 
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
None yet
Milestone
4.9.0.1
Development

No branches or pull requests
2 participants
@williamdes @saurass