Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partitioning is missing in Structure page UI #15276

Closed
sky93 opened this issue May 17, 2019 · 13 comments
Closed

Partitioning is missing in Structure page UI #15276

sky93 opened this issue May 17, 2019 · 13 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Projects
Milestone

Comments

@sky93
Copy link

sky93 commented May 17, 2019

Hello,

I cannot find Partitioning feature in table structure tab. I'm using the latest version of PMA (4.8.5) but I can't find partitioning section anywhere. How can I bring partitioning feature back ?

part

@williamdes williamdes added the Bug A problem or regression with an existing feature label May 17, 2019
@williamdes williamdes added this to Needs triage in issues via automation May 17, 2019
@williamdes
Copy link
Member

@sky93 Yes, strange ..
Thanks for reporting

@DanialV
Copy link

DanialV commented May 18, 2019

Same issue here any fix for this bug?

@williamdes
Copy link
Member

@DanialV @sky93 This is not a bug, you do not have the partition plugin enabled.
See: https://demo.phpmyadmin.net/QA_4_8/tbl_create.php?server=1&db=opengis

run

SHOW PLUGINS

If you have partition an not partition option in the GUI comment on this issue please.

https://demo.phpmyadmin.net/QA_4_8/server_plugins.php?server=1
https://demo.phpmyadmin.net/QA_4_8/server_plugins.php

issues automation moved this from Needs triage to Closed May 18, 2019
@williamdes williamdes added invalid and removed Bug A problem or regression with an existing feature labels May 18, 2019
@williamdes williamdes self-assigned this May 18, 2019
@sky93
Copy link
Author

sky93 commented May 18, 2019

There's a problem here. In MariaDB when I run SHOW PLUGINS I can verify than partition is active and enabled. In MySQL I'm sure partition is enabled because I could create a table with partitioning:

CREATE TABLE ti (id INT, amount DECIMAL(7,2), tr_date DATE)
    ENGINE=INNODB
    PARTITION BY HASH( MONTH(tr_date) )
    PARTITIONS 6;

And I could verify partitions using this query:

SELECT PARTITION_NAME, TABLE_ROWS FROM INFORMATION_SCHEMA.PARTITIONS WHERE TABLE_NAME='ti'

So partitioning is enabled but doesn't show up in SHOW PLUGINS. I guess this problem is only for MySQL 8.0 because I tired SHOW PLUGINS in MariaDB and Mysql 5 and it's showing partition.

I guess partitioning is enabled in https://demo.phpmyadmin.net/QA_4_8 (Mysql) server too but not showing up in SHOW PLUGINS

@williamdes williamdes reopened this May 18, 2019
issues automation moved this from Closed to Needs triage May 18, 2019
@williamdes williamdes added Bug A problem or regression with an existing feature and removed invalid labels May 18, 2019
@williamdes
Copy link
Member

@sky93 Thanks !
MySQL 8.0 seems to have some native handling for partitions

@williamdes williamdes moved this from Needs triage to Medium priority in issues May 18, 2019
@williamdes
Copy link
Member

williamdes commented May 18, 2019

CREATE TABLE ti (id INT, amount DECIMAL(7,2), tr_date DATE)
    ENGINE=MyISAM
    PARTITION BY HASH( MONTH(tr_date) )
    PARTITIONS 6;

MySQL 5.7: Warning: #1287 The partition engine, used by table 'public.ti', is deprecated and will be removed in a future release. Please use native partitioning instead.

MySQL 8.0: Error: #1178 - The storage engine for the table doesn't support native partitioning

Notice the MyISAM
Note: same behavior on PerconaDB

@williamdes
Copy link
Member

MariaDB is not affected.

@williamdes
Copy link
Member

https://dev.mysql.com/doc/refman/8.0/en/partitioning.html

It is not possible to disable partitioning support by the InnoDB storage engine.

@sky93
Copy link
Author

sky93 commented May 18, 2019

MyISAM

Yes in MySQL 8.0 MyISAM engine doesn't support partitioning. It seems partitioning is enabled by default in MySQL 8.0.

@williamdes
Copy link
Member

@DanialV @sky93 Can you please apply the patch 09d20e8 and tell me if everything looks okay

Tested on https://phpmyadmin-pr-7.wdes.eu.org https://phpmyadmin-pr-6.wdes.eu.org (public/public) and was OK

If you approve the change it goes directly for next release (4.8.6) 🎉 🚀

@sky93
Copy link
Author

sky93 commented May 18, 2019

Yes it's now fixed 🎉😍 Thank you so much for the fix.

williamdes added a commit that referenced this issue May 18, 2019
 Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes added this to the 4.8.6 milestone May 18, 2019
@williamdes
Copy link
Member

The fix will be part of 4.8.6
Thanks for helping !

issues automation moved this from Medium priority to Closed May 18, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Development

No branches or pull requests

3 participants