Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto_increment field is too small #15287

Closed
klaus-donnert opened this issue May 21, 2019 · 7 comments
Closed

auto_increment field is too small #15287

klaus-donnert opened this issue May 21, 2019 · 7 comments
Assignees
Labels
Bug A problem or regression with an existing feature good first issue newbie ui Issues relating to the user interface
Projects
Milestone

Comments

@klaus-donnert
Copy link

The auto_increment field only shows 5 most significant digits of numbers greater than 99999

Steps to reproduce the behavior:

  1. ( I'm using the latest Chrome 74.x ) Go to a table with 100000 or more rows
  2. Click on operations
  3. Scroll down to Table Options
  4. See error

Expected behavior: I expect to see all of the digits of the auto-increment value in the AUTO_INCREMENT field. (I believe this is caused by the default field size property of the input type="number" )

The example table pictured below has 23402301 rows but the field only shows 23402

Screenshot:
image

  • Browser: Chrome 74
  • Operating system: Windows 10
@testtubeme
Copy link

I can reproduce. Only the first 5 digits are visible, however in my 102,000 row table all digits were present in the text box, the width is just not great enough to show them. clicking in, ctrl+a then ctrl+c selects and copies all 6 digits (also moving the cursor left and right with the arrow keys will show the left and right "side" of the number as expected).

@williamdes williamdes added the Bug A problem or regression with an existing feature label May 22, 2019
@williamdes williamdes added this to Needs triage in issues via automation May 22, 2019
@williamdes
Copy link
Member

This is only an UI issue
image
I suggest to set the width attribute to width: min-content
image

@williamdes williamdes added good first issue newbie ui Issues relating to the user interface labels May 27, 2019
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues May 27, 2019
@anksh1997
Copy link
Contributor

Hi @williamdes Sir, I would like to help a bit on this issue, I have reproduced the bug in my local environment and inspected using chrome-dev tools and know exactly what I have to do. Please guide me.

@williamdes
Copy link
Member

Hi @asprazz glad that you want to help us ;)
First clone the phpMyAdmin repository and create a branch from the QA_4_8 branch, give it a name and start working on it.
I think that you will maybe have to add a css class or ( inline the style but this is not a good idea (see #12262 ) )
Do not forget that we have multiple themes :)

Then when you create the commit please use the --signoff option to add your signoff line in the commit body, please use your real name (this option is an agreement to our policy, see CONTRIBUTING.md).

Then go to the pull-request page and create a pull-request, use QA_4_8 as a target

I will review the PR and merge if everything is good ;)

@anksh1997
Copy link
Contributor

Hi @asprazz glad that you want to help us ;)
First clone the phpMyAdmin repository and create a branch from the QA_4_8 branch, give it a name and start working on it.
I think that you will maybe have to add a css class or ( inline the style but this is not a good idea (see #12262 ) )
Do not forget that we have multiple themes :)

Then when you create the commit please use the --signoff option to add your signoff line in the commit body, please use your real name (this option is an agreement to our policy, see CONTRIBUTING.md).

Then go to the pull-request page and create a pull-request, use QA_4_8 as a target

I will review the PR and merge if everything is good ;)

Thank You Sir. Looking forward for the change. Don't worry I won't be adding the inline css though :)
I just have to add a class and style to /themes/original/css/common.css.php and /themes/pmahomme/css/common.css.php Right?

@williamdes
Copy link
Member

I just have to add a class and style to /themes/original/css/common.css.php and /themes/pmahomme/css/common.css.php Right?

Right, and on the input (if it does not have one) :)

williamdes added a commit that referenced this issue May 27, 2019
Fixes: #15287
Pull-request: #15294
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue May 27, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this May 27, 2019
@williamdes williamdes added this to the 4.8.6 milestone May 27, 2019
issues automation moved this from to be fixed soon to Closed May 27, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature good first issue newbie ui Issues relating to the user interface
Projects
issues
  
Closed
Development

No branches or pull requests

4 participants