Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift-click in Export misses checkbox #15327

Closed
svivian opened this issue Jun 12, 2019 · 2 comments
Closed

Shift-click in Export misses checkbox #15327

svivian opened this issue Jun 12, 2019 · 2 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
Milestone
4.9.2

Comments

@svivian
Copy link
Contributor

svivian commented Jun 12, 2019

Describe the bug

Using Shift + click on the checkboxes in Export does not select the correct tables.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Export
  2. Click on Custom
  3. Under Tables, deselect all tables using the two checkboxes at the top.
  4. Click a checkbox for a table (left hand column).
  5. Hold Shift and click another checkbox further down.

Expected behavior

All tables between the first and second boxes (inclusive) to be checked.

But it misses the second box. For example you click the 2nd then Shift-click 7th, boxes 2, 4, 5, 6 and 7 are checked but not 3.

Server configuration

  • Operating system: Mac
  • Web server: both Mac localhost and Windows server
  • Database version: 5.7.24
  • PHP version: 7.2
  • phpMyAdmin version: 4.9.0.1

Client configuration

  • Browser: Chrome
  • Operating system: macOS 10.14.5
@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface labels Jun 14, 2019
@williamdes williamdes added this to Needs triage in issues via automation Jun 14, 2019
@williamdes williamdes moved this from Needs triage to Medium priority in issues Jun 16, 2019
@falconfx falconfx mentioned this issue Jun 18, 2019
Closed
6 tasks
@falconfx
Copy link
Contributor

I am still trying to validate the PR so that it passes all the tests, but here I have made a possible approach to the solution #15343

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jun 22, 2019
@williamdes williamdes mentioned this issue Nov 20, 2019
Closed
@saulotoledo saulotoledo mentioned this issue Nov 20, 2019
Merged
@williamdes williamdes self-assigned this Nov 20, 2019
@williamdes williamdes modified the milestones: 5.0.0, 4.9.2 Nov 20, 2019
ibennetch pushed a commit that referenced this issue Nov 22, 2019
@williamdes
Add ChangeLog entry for #15327
348904f 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Medium priority to Closed Nov 22, 2019
@ibennetch
Copy link
Member

This issue was fixed with the release of phpMyAdmin 4.9.2. Thank you for reporting this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
4.9.2
Development

No branches or pull requests
4 participants
@svivian @ibennetch @williamdes @falconfx