Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two factor auth setting is not retained after modifying some other config #15351

Closed
csware opened this issue Jun 24, 2019 · 2 comments
Closed

Two factor auth setting is not retained after modifying some other config #15351

csware opened this issue Jun 24, 2019 · 2 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.0.1

Comments

@csware
Copy link
Contributor

csware commented Jun 24, 2019

Describe the bug

Set up two factor authentication in PHPMyAdmin and then change a setting. See that 2FA is not enabled any more.

To Reproduce

Steps to reproduce the behavior:

  1. Log in
  2. Setup 2FA
  3. Logout
  4. Login with 2FA enabled
  5. Go to setting, functions and toggle version checks
  6. See that 2FA is not enabled any more

Expected behavior

2FA should still be enabled.

Server configuration

  • Operating system: Debian 9.8
  • Web server: Apache 2.4
  • Database version: MariaDB 10.1.38
  • PHP version: 7.3.6
  • phpMyAdmin version: 4.9.0.1

Client configuration

  • Browser: Firefox 67.0.4
  • Operating system: Win7 x64
@williamdes williamdes added the Bug A problem or regression with an existing feature label Jul 28, 2019
@williamdes williamdes added this to Needs triage in issues via automation Jul 28, 2019
@williamdes williamdes moved this from Needs triage to Medium priority in issues Aug 11, 2019
@victorphoenix3
Copy link
Contributor

I'll try to fix this bug.

@williamdes
Copy link
Member

@victorphoenix3 please apply fix for #15724 before trying to fix

victorphoenix3 added a commit to victorphoenix3/phpmyadmin that referenced this issue Jan 5, 2020
@victorphoenix3
Fix phpmyadmin#15351.
fa24c5f 
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
@victorphoenix3 victorphoenix3 mentioned this issue Jan 5, 2020
Merged
6 tasks
@williamdes williamdes added this to the 5.0.1 milestone Jan 7, 2020
@williamdes williamdes self-assigned this Jan 7, 2020
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 7, 2020
williamdes added a commit that referenced this issue Jan 7, 2020
@williamdes
Merge #15749 - Fix #15351 - retain 2FA setting
21c1bb8 
Pull-request: #15749
Fixes: #15351
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jan 7, 2020
@williamdes
Add ChangeLog entry for #15351
e16ccbd 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Medium priority to Closed Jan 7, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.0.1
Development

No branches or pull requests
3 participants
@csware @williamdes @victorphoenix3