Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback when finished error #15388

Closed
bm322741 opened this issue Jul 11, 2019 · 4 comments
Closed

rollback when finished error #15388

bm322741 opened this issue Jul 11, 2019 · 4 comments
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
Milestone

Comments

@bm322741
Copy link

Describe the bug

executing sql with "Rollback when finished" gives error "Only INSERT, UPDATE, DELETE and REPLACE SQL queries containing transactional engine tables can be rolled back."

Single table insert on an innodb table.

statement was format: insert into table(fields) values(list),(list),(list);

A single (list) worked, multiple failed.

Executes fine without the rollback checked.

To Reproduce

Steps to reproduce the behavior:

  1. sql
  2. paste statement with "rollback when finished" checked
  3. See error

Expected behavior

Insert data and rollback

Screenshots

image
image

If applicable, add screenshots to help explain your problem.

Server configuration

  • Operating system: Fecora 29
  • Web server: apache 2.4.39
  • Database version: MariaDb 10.1.37
  • PHP version: 7.2.19
  • phpMyAdmin version: 4.9.0.1

Client configuration

  • Browser: Chrome 75.0.3770.100
  • Operating system: Windows 10 1903

Additional context

Add any other context about the problem here.

@williamdes
Copy link
Member

williamdes commented Jul 11, 2019

@bm322741 Can you send the structure of the table, especially the engine it is using ?
A SQL insert sample would be great :)

@williamdes williamdes added this to Needs triage in issues via automation Jul 11, 2019
@bm322741
Copy link
Author

bm322741 commented Jul 11, 2019

Insert of 5 rows works, but adding a 6th fails.

insert into product_additions(seq, id, created, manufacturer, manufacturer_id, code, name) 
VALUES('1','248727','2019-06-03 08:40:47','3M DBI SALA FALL PROTECTION FOR TOOLS','1481','1500003','D-Ring Tool Attachment Point'), 
('2','248728','2019-06-03 08:40:48','3M DBI SALA FALL PROTECTION FOR TOOLS','1481','1500007','D-Ring Tool Attachment Point'), 
('3','248729','2019-06-03 08:40:48','3M DBI SALA FALL PROTECTION FOR TOOLS','1481','1500009','D-Ring Tool Attachment Point'), 
('4','248730','2019-06-03 08:40:48','3M DBI SALA FALL PROTECTION FOR TOOLS','1481','1500011','Tool Cinch Attachment Point'), 
('5','248731','2019-06-03 08:40:48','3M DBI SALA FALL PROTECTION FOR TOOLS','1481','1500013','Tool Cinch Attachment Point'),
('6','248732','2019-06-03 08:40:48','3M DBI SALA FALL PROTECTION FOR TOOLS','1481','1500015','Tool Cinch Attachment Point');

CREATE TABLE `product_additions` (
  `seq` int(11) NOT NULL,
  `id` int(11) NOT NULL,
  `created` datetime NOT NULL,
  `manufacturer` varchar(100) NOT NULL,
  `manufacturer_id` int(11) NOT NULL,
  `code` varchar(100) NOT NULL,
  `name` varchar(100) NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

--
-- Indexes for dumped tables
--

--
-- Indexes for table `product_additions`
--
ALTER TABLE `product_additions`
  ADD PRIMARY KEY (`seq`),
  ADD UNIQUE KEY `id` (`id`),
  ADD KEY `manufacturer_id` (`manufacturer_id`);

@williamdes
Copy link
Member

Are you sure your data is correct?

I could reproduce the issue when pasting all the content (data and structure)

But could not using only the data you sent

So, in conclusion : issue reproduced

Dataset:

insert into product_additions(seq, id, created, manufacturer, manufacturer_id, code, name) 
VALUES('1','248727','2019-06-03 08:40:47','3M DBI SALA FALL PROTECTION FOR TOOLS','1481','1500003','D-Ring Tool Attachment Point'), 
('2','248728','2019-06-03 08:40:48','3M DBI SALA FALL PROTECTION FOR TOOLS','1481','1500007','D-Ring Tool Attachment Point'), 
('3','248729','2019-06-03 08:40:48','3M DBI SALA FALL PROTECTION FOR TOOLS','1481','1500009','D-Ring Tool Attachment Point'), 
('4','248730','2019-06-03 08:40:48','3M DBI SALA FALL PROTECTION FOR TOOLS','1481','1500011','Tool Cinch Attachment Point'), 
('5','248731','2019-06-03 08:40:48','3M DBI SALA FALL PROTECTION FOR TOOLS','1481','1500013','Tool Cinch Attachment Point'),
('5','248732','2019-06-03 08:40:48','3M DBI SALA FALL PROTECTION FOR TOOLS','1481','1500015','Tool Cinch Attachment Point');

I duplicated the ID=5

@williamdes williamdes added the Bug A problem or regression with an existing feature label Jul 11, 2019
@Tithugues
Copy link
Contributor

It seems that from the 4.6 (and maybe before) it was already broken.

@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Aug 11, 2019
@williamdes williamdes added this to the 4.9.1 milestone Aug 20, 2019
@williamdes williamdes self-assigned this Aug 20, 2019
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Aug 20, 2019
williamdes added a commit that referenced this issue Aug 20, 2019
Fixes: #15388
Pull-request: #15408

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Aug 20, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Aug 20, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Development

No branches or pull requests

3 participants