Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

current page indicator after deleting all rows on current page #15389

Closed
bm322741 opened this issue Jul 12, 2019 · 4 comments
Closed

current page indicator after deleting all rows on current page #15389

bm322741 opened this issue Jul 12, 2019 · 4 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.1.0

Comments

@bm322741
Copy link

Describe the bug

Not really bug but a usability issue.

After using "Check All" and deleting rows the "current page" is set to 1 with no records which gives the impression the table is now empty [which it isn't]

If there is 1 row and I delete using the "delete" button [vs the checkbox] the "current page" stays the same with no rows [more intuitive that there is more data in the table].

To Reproduce

Steps to reproduce the behavior:

  1. Go to browse
  2. go to last page
  3. select "Check All"
  4. Click "Delete"
  5. Current page is reset to 1 but no data displayed.

Expected behavior

If the current page is reset to 1, show the data for page 1.

Preferred would be to stay on the page with no data [as in using the delete link vs checkbox], or go to the previous page [with corresponding data].

Screenshots

image
image
image
image
image

If applicable, add screenshots to help explain your problem.

Server configuration

  • Operating system: Fedora 29
  • Web server: apache 2.4.39
  • Database version: MariaDB 10.1.37
  • PHP version: 7.2.19
  • phpMyAdmin version: 4.9.0.1

Client configuration

  • Browser: Chrome
  • Operating system: Windows 10 1903

Additional context

Add any other context about the problem here.
@williamdes williamdes added the Bug A problem or regression with an existing feature label Jul 28, 2019
@williamdes williamdes added this to Needs triage in issues via automation Aug 11, 2019
@williamdes williamdes moved this from Needs triage to Not reproduced in issues Aug 11, 2019
@kartik1000
Copy link
Contributor

@williamdes This problem is caused only when we delete all the rows on the last page. When we delete the rows on some other page the rows next to the deleted page are moved to that page. I think we can edit the description to avoid any confusion.

@williamdes williamdes self-assigned this Feb 18, 2020
@williamdes williamdes mentioned this issue May 26, 2020
Closed
@shucon
Copy link
Contributor

shucon commented Jan 25, 2021

The issue still exists, on deleting all rows from the last page, the current page number displayed is 1 but the data isn't shown accordingly.
cc - @williamdes

@williamdes williamdes moved this from Not reproduced to Reproduced in issues Jan 25, 2021
@shucon
Copy link
Contributor

shucon commented Jan 26, 2021

Working on this for QA_5_1

shucon added a commit to shucon/phpmyadmin that referenced this issue Jan 27, 2021
@shucon
Fixes: phpmyadmin#15389
1fb2445 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@shucon shucon mentioned this issue Jan 27, 2021
Merged
6 tasks
shucon added a commit to shucon/phpmyadmin that referenced this issue Jan 28, 2021
@shucon
Fixes: phpmyadmin#15389
62b054f 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add Unit Test

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
shucon added a commit to shucon/phpmyadmin that referenced this issue Jan 28, 2021
@shucon
Fixes: phpmyadmin#15389
e941196 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add Unit Test

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix Lint

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
shucon added a commit to shucon/phpmyadmin that referenced this issue Jan 28, 2021
@shucon
Fixes: phpmyadmin#15389
793bf77 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add Unit Test

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Fix Lint

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Add comment

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@williamdes
Copy link
Member

OMG, while testing the fix I could reproduce the issue and ... you could have a "I dropped all rows" moment.
Thank you for fixing that @shucon !

williamdes added a commit that referenced this issue Feb 9, 2021
@williamdes
Merge #16597 - Fix #15389 - reset current page indicator after deleti…
e71102a 
…ng all rows to current page and not page 1

Pull-request: #16597
Fixes: #15389

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 9, 2021
@williamdes
Add a ChangeLog entry for #15389
d9c4be4 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Reproduced to Closed Feb 9, 2021
@williamdes williamdes added this to the 5.1.0 milestone Feb 9, 2021
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.1.0
Development

No branches or pull requests
4 participants
@williamdes @shucon @kartik1000 @bm322741