Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tables added from other databases are not collapsing in the designer section #15446

Closed
Bournvita1998 opened this issue Aug 19, 2019 · 0 comments
Closed

Tables added from other databases are not collapsing in the designer section #15446

Bournvita1998 opened this issue Aug 19, 2019 · 0 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues Designer
Milestone
4.9.1

Comments

@Bournvita1998
Copy link
Contributor

Describe the bug

In the designer section, after we add a table from other databases, the tables are not collapsing when clicked on 'v' button on the table.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the designer of a database
  2. Click "add the tables from other databases" from left panel in the designer.
  3. Add a table
  4. Click on the collapsing icon('v') on the table

Expected behavior

It's expected that the table should be collapsed when clicked 'v' and should be expanded when clicked '>'.

Screenshots

Selection_086

Tables in the red box couldn't be collapsed rght now.
@williamdes williamdes added the Bug A problem or regression with an existing feature label Aug 20, 2019
@williamdes williamdes added this to Needs triage in issues via automation Aug 20, 2019
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Aug 20, 2019
@williamdes williamdes added this to To Do in Designer Aug 20, 2019
@Tithugues Tithugues mentioned this issue Aug 20, 2019
Merged
7 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Aug 20, 2019
@williamdes williamdes moved this from To Do to Done in Designer Aug 22, 2019
williamdes added a commit that referenced this issue Aug 22, 2019
@williamdes
Merge #15448 - Fix many bugs when adding new tables to designer
5940d11 
Fixes: #15446
Pull-request: #15448
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Aug 22, 2019
@williamdes
Fix some bugs with strange table and database names
a23f2ba 
- Fix export
- Fix split on . to have db and table
- Replace some $_REQUEST occurences
- Add translations to "add tables from another database" : "None" > strNone
- Refactor the ugly code that used globals to use an object "DesignerTable"
- Fix save a new added table
- Fix delete page items
- Fix more bugs

Fixes: #15446
Fixes: #13370
Fixes: #14945
Closes: #15438

Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Aug 23, 2019
@williamdes williamdes self-assigned this Aug 23, 2019
@williamdes williamdes added this to the 4.9.1 milestone Aug 23, 2019
williamdes added a commit that referenced this issue Aug 23, 2019
@williamdes
Add ChangeLog entries for #15446 and #14945
0594a3a 
Reference: a23f2ba
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes mentioned this issue Jan 15, 2020
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
Designer
Done
issues
  
Closed
Milestone
4.9.1
Development

No branches or pull requests
2 participants
@williamdes @Bournvita1998