Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables added from other databases are not collapsing in the designer section #15446

Closed
Bournvita1998 opened this issue Aug 19, 2019 · 0 comments

Comments

@Bournvita1998
Copy link
Contributor

commented Aug 19, 2019

Describe the bug

In the designer section, after we add a table from other databases, the tables are not collapsing when clicked on 'v' button on the table.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the designer of a database
  2. Click "add the tables from other databases" from left panel in the designer.
  3. Add a table
  4. Click on the collapsing icon('v') on the table

Expected behavior

It's expected that the table should be collapsed when clicked 'v' and should be expanded when clicked '>'.

Screenshots

Selection_086

Tables in the red box couldn't be collapsed rght now.

@williamdes williamdes added the bug label Aug 20, 2019

@williamdes williamdes added this to Needs triage in issues via automation Aug 20, 2019

@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Aug 20, 2019

Tithugues added a commit to Tithugues/phpmyadmin that referenced this issue Aug 20, 2019
Fix phpmyadmin#15446 Tables added from other databases are not collap…
…sing in the designer section

The events to link all buttons to collapse tables were initialized at page loading. But when a new table was added, the event wasn't declared for this one.
With this commit, the event is now also declared on table addition.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>

@williamdes williamdes added this to To Do in Designer Aug 20, 2019

@williamdes williamdes added the has-pr label Aug 20, 2019

Tithugues added a commit to Tithugues/phpmyadmin that referenced this issue Aug 20, 2019
Fix phpmyadmin#15446 Tables added from other databases are not collap…
…sing in the designer section

The events to link all buttons to collapse tables were initialized at page loading. But when a new table was added, the event wasn't declared for this one.
With this commit, the event is now also declared on table addition.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>

@williamdes williamdes moved this from To Do to Done in Designer Aug 22, 2019

williamdes added a commit that referenced this issue Aug 22, 2019
Merge #15448 - Fix many bugs when adding new tables to designer
Fixes: #15446
Pull-request: #15448
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Aug 22, 2019
Fix some bugs with strange table and database names
- Fix export
- Fix split on . to have db and table
- Replace some $_REQUEST occurences
- Add translations to "add tables from another database" : "None" > strNone
- Refactor the ugly code that used globals to use an object "DesignerTable"
- Fix save a new added table
- Fix delete page items
- Fix more bugs

Fixes: #15446
Fixes: #13370
Fixes: #14945
Closes: #15438

Signed-off-by: William Desportes <williamdes@wdes.fr>

issues automation moved this from to be fixed soon to Closed Aug 23, 2019

@williamdes williamdes self-assigned this Aug 23, 2019

@williamdes williamdes added this to the 4.9.1 milestone Aug 23, 2019

williamdes added a commit that referenced this issue Aug 23, 2019
Add ChangeLog entries for #15446 and #14945
Reference: a23f2ba
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.