No profiling output when the result has no rows

[mvorisek]

When the result has zero rows, the profiling data is not displayed.

More specificaly only the #15209 MySQL deprecation warning is displayed

[williamdes]

select null from dual where false;

Source: https://stackoverflow.com/a/38586825/5155484

Reproduced.

[williamdes]

If someone wants to find a fix, the starting point is:

phpmyadmin/libraries/classes/Sql.php

Lines 2240 to 2271 in 9178602

	if ((0 == $num_rows && 0 == $unlim_num_rows)
	|| $analyzed_sql_results['is_affected']
	) {
	$html_output = $this->getQueryResponseForNoResultsReturned(
	$analyzed_sql_results, $db, $table,
	isset($message_to_show) ? $message_to_show : null,
	$num_rows, $displayResultsObject, $extra_data,
	$pmaThemeImage, isset($result) ? $result : null,
	$sql_query, isset($complete_query) ? $complete_query : null
	);
	} else {
	// At least one row is returned -> displays a table with results
	$html_output = $this->getQueryResponseForResultsReturned(
	isset($result) ? $result : null,
	$analyzed_sql_results,
	$db,
	$table,
	isset($message) ? $message : null,
	isset($sql_data) ? $sql_data : null,
	$displayResultsObject,
	$pmaThemeImage,
	$unlim_num_rows,
	$num_rows,
	isset($disp_query) ? $disp_query : null,
	isset($disp_message) ? $disp_message : null,
	$profiling_results,
	isset($query_type) ? $query_type : null,
	isset($selectedTables) ? $selectedTables : null,
	$sql_query,
	isset($complete_query) ? $complete_query : null
	);
	}

$profiling_results is sent only if there is one or more rows to display

[anksh1997]

Hie I am not clear about profiling output, what kind of profile output do we want..
I am getting
MySQL returned an empty result set (i.e. zero rows). (Query took 0.0005 seconds.)
is this one?
My bad :) Didn't understand at first .. what was the root

[ShailuJain]

I have solved this issue @williamdes do review my pr #15573

[williamdes]

@ShailuJain your PR looks okay, I will have to rebase it before merging
But it will be merged if my final test shows that you successfully solved the issue :)

[ShailuJain]

Okay, Thanks. I will love to contribute more to phpmyadmin.

[williamdes]

@ShailuJain we will be very happy to have your contributions ;) !