Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plus sign (+) in the table or database name when configuring foreign keys #15482

Closed
tryfunc opened this issue Oct 1, 2019 · 0 comments
Closed

plus sign (+) in the table or database name when configuring foreign keys #15482

tryfunc opened this issue Oct 1, 2019 · 0 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
4.9.2

Comments

@tryfunc
Copy link
Contributor

tryfunc commented Oct 1, 2019

Describe the bug

Target table select box (Foreign -> table) is empty if the current table or database name contains a plus sign (+).

The problem is that the ajax request to tbl_relation.php includes non-url-encoded parameters the table and the db.

To Reproduce

Steps to reproduce the behavior:

  1. Create database '+testdb'. (innodb).
  2. Create table 'test' in database '+testdb'.
  3. Go to table 'test' -> 'Structure' -> 'Relation view'.
  4. Select any database (with innodb table) in 'Foreign key constraint (INNODB)'.

Server configuration

  • Operating system: Debian 9.11
  • Web server: nginx + php-fpm
  • Database version: 5.7
  • PHP version: 7.0
  • phpMyAdmin version: 4.9.0.1

Client configuration

  • Browser: Chromium 73.0.3683.75
  • Operating system: Debian 9.11
@tryfunc tryfunc mentioned this issue Oct 1, 2019
Merged
@williamdes williamdes added this to Needs triage in issues via automation Oct 1, 2019
@williamdes williamdes added Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Oct 1, 2019
@williamdes williamdes moved this from Needs triage to ready to merge in issues Oct 1, 2019
@williamdes williamdes added this to the 4.9.2 milestone Oct 1, 2019
williamdes added a commit that referenced this issue Oct 17, 2019
@williamdes
Fix #15482 - plus sign (+) in the table or database name when configu…
99cade4 
…ring foreign keys

Fixes: #15482
Pull-request: #15483

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Oct 17, 2019
@williamdes
Add ChangeLog entry for #15482
d9e5414 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from ready to merge to Closed Oct 17, 2019
@williamdes williamdes self-assigned this Oct 17, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
4.9.2
Development

No branches or pull requests
2 participants
@williamdes @tryfunc