Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify ReCaptcha to allow for custom siteVerifyUrl value #15496

Closed
Dubz opened this issue Oct 7, 2019 · 0 comments
Closed

Modify ReCaptcha to allow for custom siteVerifyUrl value #15496

Dubz opened this issue Oct 7, 2019 · 0 comments
Assignees
@williamdes
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.1.0

Comments

@Dubz
Copy link

Dubz commented Oct 7, 2019

Is your feature request related to a problem? Please describe.

Web servers behind firewalls that cannot reach google.com are unable to authenticate ReCaptcha responses.

Describe the solution you'd like

Allow use of customizing the siteVerifyUrl in the ReCaptcha\RequestMethod class constructors

Describe alternatives you've considered

Manually modifying phpMyAdmin after install/updates, but is a nuisance to troubleshoot if forgotten.

Additional context

  • phpMyAdmin version:

See PR #15495 for the necessary code changes.
Apparently I am not allowed to do the work for the maintainers without providing personal information. Here is my feature request instead, if that's not an accepted route to take.
@williamdes williamdes added this to Needs triage in issues via automation Oct 22, 2019
@williamdes williamdes added the enhancement A feature request for improving phpMyAdmin label Oct 22, 2019
@williamdes williamdes moved this from Needs triage to Enhancements in issues Oct 22, 2019
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Oct 22, 2019
@Dubz Dubz mentioned this issue Oct 22, 2019
Merged
@williamdes williamdes added this to the 5.1.0 milestone Mar 10, 2020
@williamdes williamdes self-assigned this May 2, 2020
williamdes added a commit that referenced this issue May 2, 2020
@williamdes
Add a ChangeLog entry for #15496
4e92395 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Enhancements to Closed May 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.1.0
Development

No branches or pull requests
2 participants
@Dubz @williamdes