Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unparenthesized a ? b : c ? d : e is deprecated. #15499

Closed
tm8544 opened this issue Oct 9, 2019 · 3 comments
Closed

Unparenthesized a ? b : c ? d : e is deprecated. #15499

tm8544 opened this issue Oct 9, 2019 · 3 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
4.9.2

Comments

@tm8544
Copy link

tm8544 commented Oct 9, 2019 •
edited

With php 7.4.0RC3 & phpmyadmin 4.9.1 I get the following notice in Apache log

PHP Deprecated: Unparenthesized a ? b : c ? d : e is deprecated. Use either (a ? b : c) ? d : e or a ? b : (c ? d : e) in ..\libraries\tbl_columns_definition_form.inc.php on line 431

'privs_available' => (isset($GLOBALS['col_priv']) ? $GLOBALS['col_priv'] : false
        && isset($GLOBALS['is_reload_priv']) ? $GLOBALS['is_reload_priv'] : false
)

I guess it should be replaced with this:

'privs_available' => ((isset($GLOBALS['col_priv']) ? $GLOBALS['col_priv'] : false)
        && (isset($GLOBALS['is_reload_priv']) ? $GLOBALS['is_reload_priv'] : false)
 )
@dant89
Copy link
Contributor

dant89 commented Oct 10, 2019

The master branch code is slightly different so it might not need this fix?

'privs_available' => isset($GLOBALS['col_priv']) ? $GLOBALS['col_priv'] : false
        && isset($GLOBALS['is_reload_priv']) ? $GLOBALS['is_reload_priv'] : false,

@williamdes
Copy link
Member

NB: The fix must target QA_4_9 and use QA_4_9 as a base branch

@dant89 dant89 mentioned this issue Oct 10, 2019
Merged
5 tasks
@williamdes williamdes added Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Oct 10, 2019
@williamdes williamdes self-assigned this Oct 10, 2019
@williamdes williamdes added this to the 4.9.2 milestone Oct 10, 2019
@williamdes williamdes added this to Needs triage in issues via automation Oct 10, 2019
@williamdes williamdes moved this from Needs triage to ready to merge in issues Oct 10, 2019
williamdes added a commit that referenced this issue Oct 17, 2019
@williamdes
Add ChangeLog entry for #15499
21378f8 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from ready to merge to Closed Oct 17, 2019
@williamdes
Copy link
Member

williamdes commented Nov 24, 2019 •
edited

Param Value
Error Type Deprecation Notice
Error Message Unparenthesized a ? b : c ? d : e is deprecated. Use either (a ? b : c) ? d : e or a ? b : (c ? d : e)
Exception Type php
phpMyAdmin version 4.9.1
Incident count 86
Link Report#60166

This comment is posted automatically by phpMyAdmin's error-reporting-server.

Resolved.

@crazy-max crazy-max mentioned this issue Apr 3, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
4.9.2
Development

No branches or pull requests
3 participants
@dant89 @williamdes @tm8544