Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting users after a delete will delete all selected users #15511

Closed
keeshoekzema opened this issue Oct 18, 2019 · 6 comments
Closed

Exporting users after a delete will delete all selected users #15511

keeshoekzema opened this issue Oct 18, 2019 · 6 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Projects
Milestone

Comments

@keeshoekzema
Copy link

keeshoekzema commented Oct 18, 2019

Describe the bug

If you want to export a user from the Useraccounts page after you deleted a user, you will also delete the user you want to export.

I wanted to export a few users so I could import them into a new database, but before exporting I decided to delete 2 old user accounts that were no longer in use. After deleting those users I selected all users and pressed the 'with selected: export' link below the table. Instead of an export, this deleted all those users (without a confirm popup) and gave me an empty export screen.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the Useraccounts page in a server
  2. Select a user to delete
  3. Click 'go at Remove selected user accounts
  4. Click 'Ok' at the Confirm
  5. After the success notification, Select users to export
  6. Click export below the table at: "With selected: Export"

Results

You get an empty export box, and the users you selected for export have been deleted

Expected behavior

An export of the user rather than deleting the select user(s)

Server configuration

  • Latest phpmyadmin/phpmyadmin docker container
  • Database version: Percona 8.0.12
  • phpMyAdmin version: 4.9.1

Client configuration

  • Browser: Firefox 69
  • Operating system: Ubuntu 19.10
@williamdes williamdes added the Bug A problem or regression with an existing feature label Oct 18, 2019
@williamdes williamdes added this to the 4.9.2 milestone Oct 18, 2019
@williamdes williamdes added this to Needs triage in issues via automation Oct 18, 2019
@williamdes williamdes moved this from Needs triage to High priority in issues Oct 18, 2019
@williamdes
Copy link
Member

@keeshoekzema Thank you for reporting this to us !

@williamdes
Copy link
Member

You can even do, Delete>Cancel>Export and the user will be deleted

williamdes added a commit that referenced this issue Oct 18, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from High priority to Closed Oct 18, 2019
@williamdes
Copy link
Member

@keeshoekzema Can you try the patch 7dca016

It solved the issue on my side.

@williamdes williamdes self-assigned this Oct 18, 2019
@ibennetch
Copy link
Member

Thanks for the report.

@williamdes @MauricioFauth I think this is important enough to release 4.9.2 rather soon, do you agree? It's currently scheduled for a month from now.

@keeshoekzema
Copy link
Author

@williamdes yes, that patch fixed it for me as well.

@williamdes
Copy link
Member

@ibennetch I agree but not before https://github.com/phpmyadmin/phpmyadmin/issues/15485 is solved and I upstream some of the patch from https://salsa.debian.org/phpmyadmin-team/phpmyadmin/issues/25#note_114115

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Development

No branches or pull requests

3 participants