Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught TypeError: htmlspecialchars() in NavigationTree #15540

Closed
b3acon opened this issue Oct 30, 2019 · 2 comments
Closed

Uncaught TypeError: htmlspecialchars() in NavigationTree #15540

b3acon opened this issue Oct 30, 2019 · 2 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature
Projects
issues
Milestone
5.0.0

Comments

@b3acon
Copy link

b3acon commented Oct 30, 2019

Describe the bug

after copy a db over options. the 5.0.0-alpha1 locked me out with this fatal.error.
used the default options to copy it.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'select a database'
  2. Click on 'options'
  3. Fill out 'new databse name'
  4. Click on 'copy databse'
  5. See error
Fatal error: Uncaught TypeError: htmlspecialchars() expects parameter 1 to be string, int given in /libraries/classes/Navigation/NavigationTree.php:787 Stack trace: 
#0 /libraries/classes/Navigation/NavigationTree.php(787): htmlspecialchars(125612) 
#1 /libraries/classes/Navigation/NavigationTree.php(856): PhpMyAdmin\Navigation\NavigationTree->groupNode(Object(PhpMyAdmin\Navigation\Nodes\Node)) 
#2 /libraries/classes/Navigation/NavigationTree.php(856): PhpMyAdmin\Navigation\NavigationTree->groupNode(Object(PhpMyAdmin\Navigation\Nodes\Node))
#3 /libraries/classes/Navigation/NavigationTree.php(690): PhpMyAdmin\Navigation\NavigationTree->groupNode(Object(PhpMyAdmin\Navigation\Nodes\NodeDatabaseContainer)) 
#4 /rp-h in /libraries/classes/Navigation/NavigationTree.php on line 787

Server configuration

  • Operating system: gentoo
  • Web server: apache
  • Database version: 5.7
  • PHP version: 7.3.2
  • phpMyAdmin version: 5.0.0-alpha1

Client configuration

  • Browser: chrome
  • Operating system: osx
@williamdes williamdes added the Bug A problem or regression with an existing feature label Oct 30, 2019
@williamdes williamdes added this to Needs triage in issues via automation Oct 30, 2019
@williamdes williamdes modified the milestones: 5.0.0, 5.1.0 Oct 30, 2019
@williamdes
Copy link
Member

Reproduced using this setup, the issue only occurs when you have groups
db groups

@williamdes williamdes changed the title Copy Database - Uncaught TypeError: htmlspecialchars() Uncaught TypeError: htmlspecialchars() in NavigationTree Oct 30, 2019
@williamdes williamdes self-assigned this Oct 30, 2019
@williamdes williamdes added this to the 5.0.0 milestone Oct 30, 2019
williamdes added a commit that referenced this issue Oct 30, 2019
@williamdes
Add ChangeLog entry for #15540
ab0b6e2 
Ref: 128d3a0
Yes, the commit comes from QA 4.9 and the ChangeLog is QA 5.0
This is because 4.9 users are not affected but they can still have the fix.
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member

Fixed by 128d3a0
@b3acon please apply the fix and you will be okay until next 5.0 release, I also included the fix in 4.9 as explained in ab0b6e2

issues automation moved this from Needs triage to Closed Oct 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@williamdes @b3acon