Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page contents go underneath of floating menubar in some cases #15570

Closed
anksh1997 opened this issue Nov 13, 2019 · 6 comments
Closed

Page contents go underneath of floating menubar in some cases #15570

anksh1997 opened this issue Nov 13, 2019 · 6 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
Milestone
4.9.3

Comments

@anksh1997
Copy link
Contributor

Describe the bug

Similar to #15127 of version 4.9.x A shift of panels is happening in version 5.0.12-dev

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. Go to any database
  2. Go to designer tab
  3. Refresh the page or press 'f5'
  4. Then redirect to homepage by either clicking on 'phpMyadmin' logo
    or 'home' button on the top left
  5. See error

Current behaviour

Screenshot from 2019-11-13 13-59-48

Expected behavior

Screenshot from 2019-11-13 13-59-59

A clear and concise description of what you expected to happen.

Server configuration

  • Operating system: Linux Ubuntu 16.04
  • Web server: Apache
  • PHP version: 7.1.29
  • phpMyAdmin version: 5.0.12-dev
@anksh1997 anksh1997 changed the title Panels on homescreen goes underneath of floating menubar Panels on homescreen go underneath of floating menubar Nov 13, 2019
@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Nov 13, 2019
@ShailuJain
Copy link
Contributor

Can i work on this issue?

@MauricioFauth
Copy link
Member

Hi @asprazz. Thanks for reporting this.
Looks like you are using master branch from git.
Could you please try to run the following command to see if you still have the same issue?

yarn install

@anksh1997
Copy link
Contributor Author

anksh1997 commented Nov 22, 2019 •
edited

Hi @asprazz. Thanks for reporting this.
Looks like you are using master branch from git.
Could you please try to run the following command to see if you still have the same issue?

yarn install

Yeah! sure And Confirmed about panels hiding underneath menubar

@ShailuJain
Copy link
Contributor

I have solved the issue. What branch should i create a pull request on? @williamdes @MauricioFauth

@williamdes
Copy link
Member

@ShailuJain Yes, go ahead
I had the issue on QA_4_9 so you should target QA_4_9

@williamdes williamdes added this to Needs triage in issues via automation Nov 22, 2019
@williamdes williamdes moved this from Needs triage to Reproduced in issues Nov 22, 2019
@ShailuJain ShailuJain mentioned this issue Nov 22, 2019
Merged
6 tasks
@williamdes williamdes added Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete and removed enhancement A feature request for improving phpMyAdmin labels Nov 23, 2019
@williamdes williamdes added this to the 4.9.3 milestone Nov 23, 2019
@williamdes williamdes self-assigned this Nov 23, 2019
@williamdes williamdes changed the title Panels on homescreen go underneath of floating menubar Page contents go underneath of floating menubar in some cases Nov 23, 2019
williamdes added a commit that referenced this issue Nov 23, 2019
@williamdes
Add ChangeLog entry for #15570
d7d6c44 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes moved this from Reproduced to Closed in issues Nov 23, 2019
@williamdes
Copy link
Member

williamdes commented Nov 23, 2019 •
edited

Thank you @asprazz, I wish I would could have seen this was a bug and include the fix in the 4.9.2 release..

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
4.9.3
Development

No branches or pull requests
4 participants
@MauricioFauth @williamdes @anksh1997 @ShailuJain