Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't disable "Empty"-button after clicking #15582

Closed
raimundmeyer opened this issue Nov 22, 2019 · 2 comments · Fixed by #15585
Closed

Don't disable "Empty"-button after clicking #15582

raimundmeyer opened this issue Nov 22, 2019 · 2 comments · Fixed by #15585
Assignees
@williamdes
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
Milestone
5.1.0

Comments

@raimundmeyer
Copy link

Is your feature request related to a problem? Please describe.

I'm always frustrated when I'm working with data that is inserted programatically and I want to delete it periodically in phpMyAdmin. In the browse view of a database there is a button to truncate the table, but after it is clicked, it is disabled until you refresh the page. It is btw. not disabled when the table is empty at page load.
image

Describe the solution you'd like

The "Empty" button in the table view should remain clickable after being clicked.

Additional context

current master
@Tithugues
Copy link
Contributor

@williamdes @MauricioFauth @ibennetch , do you expect to have a fix for this please?
I agree with @raimundmeyer that it's a bit annoying.

@williamdes
Copy link
Member

I agree with @raimundmeyer that it's a bit annoying.

I also agree, but it must be clear that the operation succeeded (eg: 0 rows in rows column, maybe it is already the case)

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Nov 23, 2019
@williamdes williamdes added this to Needs triage in issues via automation Nov 23, 2019
@williamdes williamdes moved this from Needs triage to Enhancements in issues Nov 23, 2019
@Tithugues Tithugues mentioned this issue Nov 23, 2019
Merged
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Nov 23, 2019
@williamdes williamdes moved this from Enhancements to ready to merge in issues Nov 23, 2019
@williamdes williamdes added this to the 5.1.0 milestone Feb 25, 2020
@williamdes williamdes self-assigned this Feb 25, 2020
williamdes added a commit that referenced this issue Feb 25, 2020
@williamdes
Merge #15585 - Fix #15582 Don't disable "Empty"-button after clicking
4cea049 
Pull-request: #15585
Fixes: #15582

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 25, 2020
@williamdes
Add ChangeLog entry for #15582
4a30500 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from ready to merge to Closed Feb 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Fix #15582 Don't disable "Empty"-button after clicking
3 participants
@Tithugues @williamdes @raimundmeyer