Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudfront https proxy #15621

Closed
hierro1981 opened this issue Dec 6, 2019 · 4 comments
Closed

Cloudfront https proxy #15621

hierro1981 opened this issue Dec 6, 2019 · 4 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Projects
Milestone

Comments

@hierro1981
Copy link

hierro1981 commented Dec 6, 2019

If phpmyadmin is deployed on an http web server behind an AWS CloudFront distribution that support https, phpmyadmin warn the user about a possible "mismatch between HTTPS indicated on the server and client".

On the libraries/classes/config.php there are already some checks, on isHttps function, for different kind of proxy but there is no AWS specifi one.
Adding the following check on it should correct the behaviour:

        ...
	} elseif (strtolower(Core::getenv('HTTP_CLOUDFRONT_FORWARDED_PROTO')) == 'https') {
            $is_https = true;
        }
        ...
@williamdes
Copy link
Member

@hierro1981 totally agree, thank you for reporting this issue

@williamdes williamdes added the Bug A problem or regression with an existing feature label Dec 6, 2019
@williamdes williamdes added this to Needs triage in issues via automation Dec 6, 2019
@williamdes williamdes moved this from Needs triage to Medium priority in issues Dec 6, 2019
@williamdes
Copy link
Member

@williamdes williamdes self-assigned this Dec 9, 2019
@williamdes williamdes added this to the 4.9.3 milestone Dec 9, 2019
williamdes added a commit that referenced this issue Dec 9, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Medium priority to Closed Dec 9, 2019
@williamdes
Copy link
Member

@hierro1981 can you please try fd2b172 before 4.9.3 is out ?

@hierro1981
Copy link
Author

@williamdes modifing my 4.9.2 config.php with the changes of fd2b172 works and remove the warning

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Development

No branches or pull requests

2 participants