Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editing a date adds .00000 and breaks re-editing the date using the picker #15629

Closed
williamdes opened this issue Dec 7, 2019 · 6 comments · Fixed by #16776
Closed

editing a date adds .00000 and breaks re-editing the date using the picker #15629

williamdes opened this issue Dec 7, 2019 · 6 comments · Fixed by #16776
Assignees
Labels
Bug A problem or regression with an existing feature
Projects
Milestone

Comments

@williamdes
Copy link
Member

I had some issues with the trailing .00000 when inserting dates

Ref: #582
Ref: b495061

Originally posted by @williamdes in #14986 (comment)

@williamdes williamdes added the Bug A problem or regression with an existing feature label Dec 7, 2019
@williamdes williamdes added this to Needs triage in issues via automation Dec 7, 2019
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Dec 7, 2019
@AshwinGinoria
Copy link
Contributor

@williamdes how can I reproduce this issue ??

@williamdes
Copy link
Member Author

williamdes commented Dec 9, 2019

@AshwinGinoria in-line edit a row with a date :)

@williamdes
Copy link
Member Author

cc @kasunchathuranga

williamdes pushed a commit to kartik1000/phpmyadmin that referenced this issue Jan 1, 2020
Fixes: phpmyadmin#15629

Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 1, 2020
@williamdes
Copy link
Member Author

CREATE TABLE `dateTimes`(
    `date` DATE NOT NULL,
    `datetime` DATETIME(6) NOT NULL,
    `ts` TIMESTAMP(6) NOT NULL,
    `time` TIME(6) NOT NULL,
    `year` YEAR(6) NOT NULL
) ENGINE = INNODB; ALTER TABLE
    `dateTimes` ADD UNIQUE(`date`, `datetime`, `ts`, `time`, `year`);
INSERT INTO `dateTimes`(`date`, `datetime`, `ts`, `time`, `year`)
VALUES(
    '2020-01-15',
    '2020-01-16 22:00:34.000396',
    '2020-01-01 22:00:34.000520',
    '22:00:34.000314',
    '2019'
);

@williamdes williamdes removed the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label May 9, 2020
@manusfreedom
Copy link
Contributor

Please fix the UI part too, because when edit a line, it resize the column while keeping displaying additional .00000, if you refresh the page .00000 disappear.
And if we past (CTRL-V) a date like 0000-00-00 00:00:00, it's add .00000.

Why the picker is directly open when using this inline edit ? It must be close like using the full form.
(Indicate me if I must open another issue for that)

@williamdes
Copy link
Member Author

Why the picker is directly open when using this inline edit ? It must be close like using the full form.

I am not sure the behaviour should be changed, open or closed by default could be set by a setting and everyone would be happy.
If you implement such setting you can open a pull-request :)

@williamdes williamdes self-assigned this Mar 31, 2021
@williamdes williamdes added this to the 5.1.1 milestone Mar 31, 2021
williamdes added a commit that referenced this issue Mar 31, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Mar 31, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
3 participants