Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer broken since update - php 5.x syntax error #15633

Closed
kloentje2 opened this issue Dec 9, 2019 · 8 comments
Closed

Designer broken since update - php 5.x syntax error #15633

kloentje2 opened this issue Dec 9, 2019 · 8 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Projects
Milestone

Comments

@kloentje2
Copy link

kloentje2 commented Dec 9, 2019

Describe the bug

The PMA Designer is broken

To Reproduce

Steps to reproduce the behavior:

  1. Update to phpMyAdmin 4.9.2-all-languages
  2. Go to PMA and select a database
  3. Select the designer
  4. Waiting................

Expected behavior

When I open the Degisner I expect that I can use it to make diagrams

https://image.prntscr.com/image/ZbSjMiR7Ro6wuMO7lDmRfA.png

Server configuration

  • Operating system: CentOS 6.10
  • Web server: Apache/2
  • Database version: 5.6.42 - MySQL Community Server (GPL)
  • PHP version: Multiserver 7.* and 5.6/4 (running on 5.6.40)
  • phpMyAdmin version: 4.9.2 (currently running on .1 because of the bug)

Client configuration

  • Browser: Chrome
  • Operating system: Windows 10
@williamdes
Copy link
Member

@kloentje2 please post the image here, I can not access it

@kloentje2
Copy link
Author

ZbSjMiR7Ro6wuMO7lDmRfA

@williamdes
Copy link
Member

williamdes commented Dec 9, 2019

@kloentje2 right click on the link and open in a new tab
if you can see an error on the new tab, post it here

And please send the php error logs if you can have them :)

BTW: you did forget to blur the DB name in the URL 😄

@kloentje2
Copy link
Author

kloentje2 commented Dec 9, 2019

@williamdes

When I access the URL from the browser (in a new tab)
Parse error: syntax error, unexpected '=' in /var/www/html/pma3/db_designer.php on line 70

But I did not change anything. Its just the tar gz file from the mirror

BTW: you did forget to blur the DB name in the URL

I knew that I forgot something :P

@kloentje2
Copy link
Author

kloentje2 commented Dec 9, 2019

        [
            $success,
            $message,
        ] = $designerCommon->saveDisplayField(
            $_POST['db'],
            $_POST['table'],
            $_POST['field']
        );
        $response->setRequestStatus($success);
        $response->addJSON('message', $message);
    } elseif ($_POST['operation'] == 'addNewRelation') {```

The error is in this line         `] = $designerCommon->saveDisplayField(`

@williamdes
Copy link
Member

@kloentje2 oh ..
Seems like I did a mistake "Since PHP 7.1, you can use short-hand list unpacking using square brackets, just like short-hand array declaration:"
https://www.php.net/manual/fr/function.list.php#122615

Change

        [
            $success,
            $message,
        ] = $designerCommon->saveDisplayField(

by

        list(
            $success,
            $message
        ) = $designerCommon->saveDisplayField(

@williamdes williamdes self-assigned this Dec 9, 2019
@kloentje2
Copy link
Author

After the update I also have this error
"phpmyadmin relation features disabled"

Do you know what to do? I already have checked the engine version, that is InnoDB

@williamdes
Copy link
Member

Do you know what to do

Yes

@kloentje2 go to the homepage and at the bottom you should see an error message, click on it and solve the issue or post the screenshot here please

I already have checked the engine version, that is InnoDB

The issue is on the "phpmyadmin" database, everything is fine on your database ;)

williamdes added a commit that referenced this issue Dec 9, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes added the Bug A problem or regression with an existing feature label Dec 9, 2019
@williamdes williamdes added this to Needs triage in issues via automation Dec 9, 2019
@williamdes williamdes moved this from Needs triage to Closed in issues Dec 9, 2019
@williamdes williamdes added this to the 4.9.3 milestone Dec 9, 2019
@williamdes williamdes changed the title Designer broken since update Designer broken since update - php 5.x syntax error Dec 9, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Development

No branches or pull requests

2 participants