Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication broken on 4.9.1 #15641

Closed
ibennetch opened this issue Dec 11, 2019 · 3 comments
Closed

Replication broken on 4.9.1 #15641

ibennetch opened this issue Dec 11, 2019 · 3 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Projects
Milestone

Comments

@ibennetch
Copy link
Member

This report comes from IRC user lembron, I have not tested it yet:

replication controlls broken for anyone? (4.9.1) and start/stop "dont work" - manually running the command via SQL the linter complains! - but success just fine and works

Replication::slaveControl() seems to issue correctly - but inside "$GLOBALS['dbi']->tryQuery" that never seems to arrive

public static function slaveControl($action, $control = null, $link = null) <- this null is bogus! - replaced with "DatabaseInterface::CONNECT_USER" as found in some other file - works - given that gitblame says thats 2 years old... wtf?

@williamdes
Copy link
Member

Is it a duplicate of #15608 ?

@williamdes williamdes added the Bug A problem or regression with an existing feature label Dec 11, 2019
@ibennetch
Copy link
Member Author

Based on his report it doesn't sound like it to me, but he's gone and I don't currently have a replication server running to test myself.

@williamdes williamdes added this to Needs triage in issues via automation Dec 11, 2019
@williamdes williamdes moved this from Needs triage to High priority in issues Dec 11, 2019
@williamdes
Copy link
Member

with "DatabaseInterface::CONNECT_USER" as found in some other file - works - given that gitblame says thats 2 years old... wtf?

I agree, years that this issue exits

@williamdes williamdes added this to the 4.9.3 milestone Dec 19, 2019
@williamdes williamdes self-assigned this Dec 19, 2019
williamdes added a commit that referenced this issue Dec 19, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from High priority to Closed Dec 19, 2019
williamdes added a commit that referenced this issue Dec 21, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Development

No branches or pull requests

2 participants