Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning: #1287 FOUND_ROWS() is deprecated #15652

Closed
OlafvdSpek opened this issue Dec 15, 2019 · 15 comments · Fixed by #16470
Closed

Warning: #1287 FOUND_ROWS() is deprecated #15652

OlafvdSpek opened this issue Dec 15, 2019 · 15 comments · Fixed by #16470
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.1.0

Comments

@OlafvdSpek
Copy link

OlafvdSpek commented Dec 15, 2019 •
edited

Warning: #1287 FOUND_ROWS() is deprecated and will be removed in a future release. Consider using COUNT(*) instead.

When clicking on Unique Values for any field.

https://demo.phpmyadmin.net/master-config/index.php?route=/table/structure&db=sakila&table=actor
@williamdes williamdes added the Bug A problem or regression with an existing feature label Dec 15, 2019
@williamdes williamdes added this to Needs triage in issues via automation Dec 15, 2019
@williamdes williamdes moved this from Needs triage to High priority in issues Dec 15, 2019
@williamdes williamdes added this to the 4.9.3 milestone Dec 15, 2019
@williamdes williamdes self-assigned this Dec 15, 2019
@rahgurung
Copy link
Contributor

Why do I get vsprintf(): Too few arguments in the link of above given server.

@williamdes
Copy link
Member

@gurrrung you are seeing #15626
You can use the 4.9.x demo server

@ShailuJain
Copy link
Contributor

Are you working on this @williamdes ? Can you help me with the steps in reproducing this issue?

@williamdes williamdes moved this from High priority to Medium priority in issues Dec 18, 2019
@williamdes
Copy link
Member

image

image

@williamdes williamdes removed this from the 4.9.3 milestone Dec 26, 2019
@victorphoenix3
Copy link
Contributor

The warning does not appear when server is MariaDb. working on this.

@kartik1000
Copy link
Contributor

@victorphoenix3 The warning is not shown because FOUND_ROWS is not being deprecated for MariaDB, but only for MySQL. You can check this by googling or also refer from here https://core.trac.wordpress.org/ticket/47280

@victorphoenix3
Copy link
Contributor

@kartik1000 so should we modify the sql to not use SQL_CALC_FOUND_ROWS anywhere. Right?

@kartik1000
Copy link
Contributor

Yes I think this should be the best possible solution since, It will do the same task for MariaDB as well and we will not need FOUND_ROWS for it as well. What do you think @williamdes

@williamdes
Copy link
Member

Yes I think this should be the best possible solution since, It will do the same task for MariaDB as well and we will not need FOUND_ROWS for it as well. What do you think @williamdes

I agree, if we can migrate out of FOUND_ROWS totally without breaking all the current servers supported

@victorphoenix3
Copy link
Contributor

I'll try to fix this :)

@kartik1000
Copy link
Contributor

@williamdes Moreover we might as well reduce the complexity of counting rows which is needed for pagination and it might also fix #15285 . What do you think?

@ghost
Copy link

ghost commented Feb 18, 2020 via email •
edited by williamdes

@williamdes
Copy link
Member

@williamdes Moreover we might as well reduce the complexity of counting rows which is needed for pagination and it might also fix #15285 . What do you think?

That would be cool if possible

Keep us updated @warlockk

@shucon
Copy link
Contributor

shucon commented Nov 6, 2020

Hey, @warlockk if you're not working on it right now I would like to take it up. 😄

@williamdes
Copy link
Member

Hey, @warlockk if you're not working on it right now I would like to take it up.

You can take this one, I will be glad to have a clean fix for it

@williamdes williamdes removed their assignment Nov 8, 2020
shucon added a commit to shucon/phpmyadmin that referenced this issue Nov 8, 2020
@shucon
Fixes: phpmyadmin#15652
f2ad667 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@shucon shucon mentioned this issue Nov 8, 2020
Merged
6 tasks
@williamdes williamdes self-assigned this Nov 12, 2020
@williamdes williamdes added this to the 5.1.0 milestone Nov 12, 2020
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Nov 12, 2020
williamdes added a commit that referenced this issue Nov 12, 2020
@williamdes
Merge #16470 - Fix #15652 - Replace deprecated FOUND_ROWS()
9320bff 
Issue: #15652
Pull-request: #16470
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Nov 12, 2020
@williamdes
Add a ChangeLog entry for #15652
8707055 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Medium priority to Closed Nov 12, 2020
@williamdes williamdes mentioned this issue Apr 24, 2021
Closed
williamdes added a commit that referenced this issue Apr 24, 2021
@williamdes
Fix #16734 - Use SQL count instead of fetch and count results
6433180 
Ref: #15652

Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Remove deprecated FOUND_ROWS() shucon/phpmyadmin
7 participants
@OlafvdSpek @williamdes @shucon @rahgurung @ShailuJain @kartik1000 @victorphoenix3