Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returns to browse page after dropping key #15662

Closed
OlafvdSpek opened this issue Dec 17, 2019 · 3 comments · Fixed by #15675
Closed

Returns to browse page after dropping key #15662

OlafvdSpek opened this issue Dec 17, 2019 · 3 comments · Fixed by #15675
Assignees
@williamdes
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
Enhancements
Milestone
5.1.0

Comments

@OlafvdSpek
Copy link

It should stay on the structure page.

https://demo.phpmyadmin.net/master-config/index.php?route=/table/structure&db=sakila&table=actor
@williamdes williamdes added the Bug A problem or regression with an existing feature label Dec 17, 2019
@williamdes williamdes added this to Needs triage in issues via automation Dec 17, 2019
@williamdes williamdes moved this from Needs triage to Low priority in issues Dec 17, 2019
victorphoenix3 added a commit to victorphoenix3/phpmyadmin that referenced this issue Dec 20, 2019
@victorphoenix3
Prevents return to Browse page.
cb4d5b2 
Fixes phpmyadmin#15662

Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
victorphoenix3 added a commit to victorphoenix3/phpmyadmin that referenced this issue Dec 20, 2019
@victorphoenix3
Prevents return to Browse page.
b666537 
Fixes phpmyadmin#15662

Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
@victorphoenix3 victorphoenix3 mentioned this issue Dec 20, 2019
Merged
6 tasks
@victorphoenix3
Copy link
Contributor

@williamdes The form returns to the browse page even after "adding" the key. Should I fix that in the PR too?

victorphoenix3 added a commit to victorphoenix3/phpmyadmin that referenced this issue Dec 20, 2019
@victorphoenix3
Prevents return to Browse page.
d85e011 
Fixes phpmyadmin#15662

Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
@williamdes
Copy link
Member

@victorphoenix3 Yes, would make sense

victorphoenix3 added a commit to victorphoenix3/phpmyadmin that referenced this issue Dec 20, 2019
@victorphoenix3
Prevents return to Browse page.
bb70930 
Fixes phpmyadmin#15662

Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
@victorphoenix3
Copy link
Contributor

@williamdes done. Ready for review.

@victorphoenix3 victorphoenix3 mentioned this issue Dec 21, 2019
Merged
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Dec 21, 2019
@williamdes williamdes modified the milestones: 5.0.1, 5.0.0, 5.1.0 Dec 21, 2019
@williamdes williamdes added enhancement A feature request for improving phpMyAdmin and removed Bug A problem or regression with an existing feature labels Jan 28, 2020
@williamdes williamdes added this to Triage zone in Enhancements via automation Jan 28, 2020
@williamdes williamdes removed this from Low priority in issues Jan 28, 2020
@williamdes williamdes moved this from Triage zone to Interface in Enhancements Jan 28, 2020
@williamdes williamdes self-assigned this Feb 25, 2020
Enhancements automation moved this from Interface to Done Feb 25, 2020
williamdes added a commit that referenced this issue Feb 25, 2020
@williamdes
Merge #15675 - Fix #15662 stay on the structure page when editing ind…
b5ecd65 
…exes

Pull-request: #15675
Fixes: #15662

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 25, 2020
@williamdes
Add ChangeLog entry for #15662
edb48b8 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue May 12, 2020
@williamdes
Remove selenium success assertions after #15662 and #15663
5c0ed71 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
Enhancements
  
Done
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Prevents return to Browse page. victorphoenix3/phpmyadmin
3 participants
@OlafvdSpek @williamdes @victorphoenix3