Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not able to unselect last column to hide it #15691

Closed
Tarun-Kachhela opened this issue Dec 23, 2019 · 6 comments · Fixed by #16934
Closed

Not able to unselect last column to hide it #15691

Tarun-Kachhela opened this issue Dec 23, 2019 · 6 comments · Fixed by #16934
Assignees
@williamdes
Labels
enhancement A feature request for improving phpMyAdmin good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Enhancements
Milestone
5.2.0

Comments

@Tarun-Kachhela
Copy link

Describe the bug

While unselecting checkboxes to hide the columns the last column is not getting unselected
resulting in the last column not being hided

Steps to reproduce the behavior:

  1. Go to pma page, select the table which has a primary key
  2. Click on 'Small down arrow icon'
  3. Uncheck all the checkbox
  4. Resulting in the last column not being hided

Expected behavior

The last column should also hide.

Screenshots

tarun
@williamdes
Copy link
Member

williamdes commented Dec 23, 2019 •
edited

I am not sure this is a bug, not allowing to show 0 columns seems okay

Can I have your thoughts @OlafvdSpek ?

@OlafvdSpek
Copy link

Hiding all columns seems weird but I don't know why you'd want to disallow it.

@Tarun-Kachhela
Copy link
Author

If not hiding the last column then the last checkbox's UI should be like it is disabled maybe we can show it disabled by using a lighter color shade
What do you think @williamdes?

@williamdes
Copy link
Member

@Tarun-Kachhela disabling the last checkbox seems like a good idea to me

@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface undecided labels Dec 24, 2019
@williamdes williamdes added this to Needs triage in issues via automation Dec 24, 2019
@williamdes williamdes moved this from Needs triage to n/a priority in issues Dec 24, 2019
@williamdes williamdes self-assigned this Mar 14, 2021
@williamdes williamdes added enhancement A feature request for improving phpMyAdmin and removed Bug A problem or regression with an existing feature undecided labels Mar 14, 2021
@williamdes williamdes removed this from n/a priority in issues Mar 14, 2021
@williamdes williamdes added this to Triage zone in Enhancements via automation Mar 14, 2021
@williamdes williamdes moved this from Triage zone to Interface in Enhancements Mar 14, 2021
@studiorms
Copy link
Contributor

Hi. I'm planning on taking a look at this issue. Which branch should I be working out of?

@williamdes
Copy link
Member

Hi. I'm planning on taking a look at this issue. Which branch should I be working out of?

Hi!
For enhancements the branch is master, for fixes it is QA_5_1.
Let me know if you need some help

@studiorms studiorms mentioned this issue May 31, 2021
Merged
6 tasks
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label May 31, 2021
@williamdes williamdes linked a pull request May 31, 2021 that will close this issue
Fix #15691 - disable last checkbox #16934
Merged
6 tasks
@williamdes williamdes added this to the 5.2.0 milestone Jul 8, 2021
williamdes added a commit that referenced this issue Jul 8, 2021
@williamdes
Add a ChangeLog entry for #15691
08df9dd 
Signed-off-by: William Desportes <williamdes@wdes.fr>
Enhancements automation moved this from Interface to Done Jul 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Enhancements
  
Done
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

Fix #15691 - disable last checkbox studiorms/phpmyadmin
4 participants
@OlafvdSpek @williamdes @Tarun-Kachhela @studiorms