Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus of active tab is lost by clicking refresh option provided by phpmyadmin. #15693

Closed
Tarun-Kachhela opened this issue Dec 24, 2019 · 7 comments
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Milestone

Comments

@Tarun-Kachhela
Copy link

Describe the bug

After using refresh feature provided by pma page the focus of the active tab is lost and setting icon at the top right of the PHPMyAdmin page is not visible.

Steps to reproduce the behavior:

  1. Go to pma page, select the any table
  2. Click on the Refresh option provided by pma.

Before clicking refresh button

SharedScreenshot

After clicking the refresh button

CorrectLostFocusNotVisibleSetting

3, The focus of the active tab has been lost And the setting icon at the top right of the page is not visible

Expected behavior

The setting icon should be visible, The Focus of the active tab should still be active after clicking refresh option.

@williamdes
Copy link
Member

Reproduced, thank you for reporting this issue !

@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface labels Dec 24, 2019
@williamdes williamdes added this to Needs triage in issues via automation Dec 24, 2019
@williamdes williamdes moved this from Needs triage to Medium priority in issues Dec 24, 2019
@Tarun-Kachhela
Copy link
Author

Can I search a solution for this @williamdes

@williamdes
Copy link
Member

@Tarun-Kachhela yes, you are welcome !
Please use QA_4_9 branch

@Tarun-Kachhela
Copy link
Author

Tarun-Kachhela commented Dec 24, 2019

can you guide me with the basic process? This is my first contribution @williamdes

@williamdes
Copy link
Member

Here is my first contribution guide:

  • Fork the repository
  • Clone the fork locally into a web folder eg:/var/www
  • Checkout QA_4_9 branch since it is a fix and create a new branch from QA_4_9
  • Run composer install
  • Create a config.inc.php if needed using the example file
  • Access your phpmyadmin website and login
  • Find or apply the fix you created
  • Do not forget to use --signoff option to add your signoff line in the commit body, please use your real name (this option is an agreement to our policy)
  • Push your changes and open a pull-request to this repository, branch: QA_4_9

Do you have any more questions @Tarun-Kachhela ?

@Tarun-Kachhela
Copy link
Author

No.
Thanks for the help

@victorphoenix3
Copy link
Contributor

@Tarun-Kachhela sorry I didnt realize you were working on this. But I think I found a possible fix.

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Dec 26, 2019
@williamdes williamdes self-assigned this Jan 2, 2020
@williamdes williamdes added this to the 5.0.1 milestone Jan 2, 2020
williamdes added a commit that referenced this issue Jan 2, 2020
Pull-request: #15703
Fixes: #15693 

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jan 2, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Medium priority to Closed Jan 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Development

No branches or pull requests

3 participants