Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum Editor Delete Icon #15726

Closed
OlafvdSpek opened this issue Dec 31, 2019 · 4 comments
Closed

Enum Editor Delete Icon #15726

OlafvdSpek opened this issue Dec 31, 2019 · 4 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature good first issue ui Issues relating to the user interface
Projects
issues
Milestone
5.0.1

Comments

@OlafvdSpek
Copy link

https://demo.phpmyadmin.net/master-config/index.php?route=/server/databases&server=2

pma
@williamdes williamdes added Bug A problem or regression with an existing feature good first issue ui Issues relating to the user interface labels Dec 31, 2019
@williamdes williamdes added this to the 5.1.0 milestone Dec 31, 2019
@williamdes williamdes added this to Needs triage in issues via automation Dec 31, 2019
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Dec 31, 2019
@yashrajbothra
Copy link
Contributor

Hey @williamdes can i work on this issue?

@williamdes
Copy link
Member

@yashrajbothra yes, you will need to use master branch

@yashrajbothra
Copy link
Contributor

Hey @williamdes , I found the problem in CSS can i change SCSS file in themes??

@williamdes
Copy link
Member

williamdes commented Jan 1, 2020 •
edited

Hey @yashrajbothra yes, you can change them and run yarn run css-compile

yashrajbothra added a commit to yashrajbothra/phpmyadmin that referenced this issue Jan 1, 2020
@yashrajbothra
phpmyadmin#15726 fixed icon by removing width
e47c0df
@yashrajbothra yashrajbothra mentioned this issue Jan 1, 2020
Merged
6 tasks
yashrajbothra added a commit to yashrajbothra/phpmyadmin that referenced this issue Jan 1, 2020
@yashrajbothra
phpmyadmin#15726 fixed icon by removing width
b42bea9 
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@williamdes williamdes modified the milestones: 5.1.0, 5.0.1 Jan 2, 2020
@williamdes williamdes self-assigned this Jan 2, 2020
williamdes added a commit that referenced this issue Jan 2, 2020
@williamdes
Merge #15730 - fix #15726 - double icon on enum editor
1b913f6 
Pull-request: #15730
Fixes: #15726 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jan 2, 2020
@williamdes
Add ChangeLog entry for #15726
9119a96 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Jan 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.0.1
Development

No branches or pull requests
3 participants
@OlafvdSpek @williamdes @yashrajbothra