Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtuality options drop-down for MariaDB #15729

Closed
OlafvdSpek opened this issue Jan 1, 2020 · 10 comments · Fixed by #15784
Closed

Virtuality options drop-down for MariaDB #15729

OlafvdSpek opened this issue Jan 1, 2020 · 10 comments · Fixed by #15784
Assignees
@williamdes
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
Milestone
5.1.0

Comments

@OlafvdSpek
Copy link 

There are two types of generated columns:

PERSISTENT (a.k.a. STORED): This type's value is actually stored in the table.
VIRTUAL: This type's value is not stored at all. Instead, the value is generated dynamically when the table is queried. This type is the default.

So it doesn't make sense to have three options..

https://mariadb.com/kb/en/generated-columns/

pma
@williamdes williamdes added ui Issues relating to the user interface undecided labels Jan 1, 2020
@williamdes williamdes changed the title Virtuality Virtuality options drop-down Jan 1, 2020
@victorphoenix3
Copy link
Contributor

@williamdes what needs to be done here?

@williamdes
Copy link
Member

@victorphoenix3 I would agree to remove an option and maybe reword persistent option

@victorphoenix3
Copy link
Contributor

@williamdes The PR #14966 added the 'stored' option for mariadb .Should I revert this change?

@OlafvdSpek
Copy link
Author

No, #14966 (comment)

@williamdes
Copy link
Member

@OlafvdSpek what needs to be done ?

@victorphoenix3
Copy link
Contributor

@OlafvdSpek Currently we show only 'stored' for mysql and both 'persistent' and 'stored' for mariadb.

@OlafvdSpek
Copy link
Author

OlafvdSpek commented Jan 12, 2020 •
edited

Yes, it seems stored is required to fix #14957 though I don't understand why. Is MariaDB returning stored rather then persistent?

Ideally pMA would merge persistent and stored into a persistent / stored option while still supporting both MariaDB and MySQL.

@victorphoenix3
Copy link
Contributor

@williamdes we are returning stored even for columns generated as persistent.
So, maybe we should remove the persistent option and just keep stored and virtual.
I will check the codebase again to make sure nothing breaks.

@OlafvdSpek
Copy link
Author

Does MariaDB 10.1 support stored?

@victorphoenix3
Copy link
Contributor

stored is only supported by 10.2.1 and later.
I will apply a check on the version.

@victorphoenix3 victorphoenix3 mentioned this issue Jan 13, 2020
Merged
@williamdes williamdes added has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete enhancement A feature request for improving phpMyAdmin and removed undecided labels Jan 15, 2020
@williamdes williamdes added this to the 5.1.0 milestone Jan 15, 2020
@williamdes williamdes added this to Needs triage in issues via automation Jan 15, 2020
@williamdes williamdes self-assigned this Jan 15, 2020
@williamdes williamdes changed the title Virtuality options drop-down Virtuality options drop-down for MariaDB Jan 15, 2020
issues automation moved this from Needs triage to Closed Jan 15, 2020
williamdes added a commit that referenced this issue Jan 15, 2020
@williamdes
Merge #15784 - Fix #15729 Improve virtuality dropdown for MariaDB
e094e69 
Pull-request: #15784
Fixes: #15729
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jan 15, 2020
@williamdes
Add ChangeLog entry for #15729
921184e 
(the STORED keyword is supported as an alias for the PERSISTENT keyword.)

https://mariadb.com/kb/en/generated-columns/#mysql-compatibility-support

Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Fixes virtuality dropdown menu victorphoenix3/phpmyadmin
3 participants
@OlafvdSpek @williamdes @victorphoenix3