Fatal javascript error on clicking "Pick from Central Columns"

[yashrajbothra]

Describe the bug

Fatal Javascript error when clicking on Pick from Central Columns
Click to goto Demo

To Reproduce

Steps to reproduce the behavior:

1. Go to 'Any table'
2. Click on 'Change -> Pick from Central Columns'
3. See error

Screenshots

Server configuration

• Operating system: Windows 10
• Web server: Apache/2.4.34
• Database version: mysqlnd 5.0.12-dev
• PHP version: 7.2.9
• phpMyAdmin version: 5.1.0-dev

Client configuration

• Browser: Chrome
• Operating system: Windows 10

[yashrajbothra]

I would like to work on this issue.

[williamdes]

@yashrajbothra you reproduced the famous "message": "makeGrid is not defined",

[yashrajbothra]

hey @williamdes #15747 this PR does not fix this issue.

[williamdes]

hey @yashrajbothra
can you reproduce the issue and post the it here "show report details"

[yashrajbothra]

Error report:

{
    "pma_version": "5.1.0-dev",
    "browser_name": "CHROME",
    "browser_version": "79.0.3945.88",
    "user_os": "Win",
    "server_software": "nginx/1.10.3",
    "user_agent_string": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.88 Safari/537.36",
    "locale": "en",
    "configuration_storage": "enabled",
    "php_version": "7.4.0",
    "script_name": "index.php",
    "exception_type": "js",
    "exception": {
        "mode": "stack",
        "name": "TypeError",
        "message": "Cannot read property 'length' of undefined",
        "stack": [
            {
                "line": "292",
                "func": "",
                "context": [
                    "            if (lastException === ex) {",
                    "                processLastException();",
                    "            }",
                    "        }, (stack.incomplete ? 2000 : 0));",
                    "",
                    "        throw ex; // re-throw to propagate to the top level (and cause wind//...",
                    "    }",
                    "",
                    "    report.subscribe = subscribe;",
                    "    report.unsubscribe = unsubscribe;",
                    "    return report;"
                ],
                "column": "",
                "uri": "js/vendor/tracekit.js?v=5.1.0-dev",
                "scriptname": "js/vendor/tracekit.js"
            },
            {
                "func": "HTMLAnchorElement.",
                "line": "3595",
                "column": "60",
                "context": [
                    "                },",
                    "                async:false",
                    "            });",
                    "        }",
                    "        var i = 0;",
                    "        var listSize = centralColumnList[db + '_' + table].length;",
                    "        var min = (listSize <= maxRows) ? listSize : maxRows;",
                    "        for (i = 0; i < min; i++) {",
                    "            fields += '
' +",
                    "                Functions.escapeHtml(centralColumnList[db + '_' + table][i]//...",
                    "                '
' + centralColumnList[//..."
                ],
                "uri": "js/functions.js?v=5.1.0-dev",
                "scriptname": "js/functions.js"
            },
            {
                "func": "HTMLAnchorElement.newFunc",
                "line": "266",
                "column": "33",
                "context": [
                    "     */",
                    "    wrapFunction: function (func) {",
                    "        if (!func.wrapped) {",
                    "            var newFunc = function () {",
                    "                try {",
                    "                    return func.apply(this, arguments);",
                    "                } catch (x) {",
                    "                    TraceKit.report(x);",
                    "                }",
                    "            };",
                    "            newFunc.wrapped = true;"
                ],
                "uri": "js/error_report.js?v=5.1.0-dev",
                "scriptname": "js/error_report.js"
            },
            {
                "func": "HTMLDocument.dispatch",
                "line": "2",
                "column": "42571",
                "context": [
                    "/*! jQuery v3.4.1 | (c) JS Foundation and other contributors | jquery.org/l//...",
                    "!function(e,t){\"use strict\";\"object\"==typeof module&&\"object\"==typeof modul//...",
                    ""
                ],
                "uri": "js/vendor/jquery/jquery.min.js?v=5.1.0-dev",
                "scriptname": "js/vendor/jquery/jquery.min.js"
            },
            {
                "func": "HTMLDocument.$event.dispatch",
                "line": "374",
                "column": "19",
                "context": [
                    "$event.dispatch = function( event ){",
                    "\tif ( $.data( this, \"suppress.\"+ event.type ) - new Date().getTime() > 0 ){",
                    "\t\t$.removeData( this, \"suppress.\"+ event.type );",
                    "\t\treturn;",
                    "\t}",
                    "\treturn $dispatch.apply( this, arguments );",
                    "};",
                    "",
                    "// event fix hooks for touch events...",
                    "var touchHooks = ",
                    "$event.fixHooks.touchstart = "
                ],
                "uri": "js/vendor/jquery/jquery.event.drag-2.2.js?v=5.1.0-dev",
                "scriptname": "js/vendor/jquery/jquery.event.drag-2.2.js"
            },
            {
                "func": "HTMLDocument.v.handle",
                "line": "2",
                "column": "40572",
                "context": [
                    "/*! jQuery v3.4.1 | (c) JS Foundation and other contributors | jquery.org/l//...",
                    "!function(e,t){\"use strict\";\"object\"==typeof module&&\"object\"==typeof modul//...",
                    ""
                ],
                "uri": "js/vendor/jquery/jquery.min.js?v=5.1.0-dev",
                "scriptname": "js/vendor/jquery/jquery.min.js"
            }
        ],
        "incomplete": "false",
        "partial": "true",
        "uri": "index.php?route=%2Ftable%2Fstructure&goto=index.php%3Froute%3D%2Ftable%2Fstructure%26amp%3Bserver%3D1&back=index.php%3Froute%3D%2Ftable%2Fstructure%26amp%3Bserver%3D1&field=city_id&change_column=1"
    }
}

[yashrajbothra]

can i use master branch as base?

[williamdes]

@yashrajbothra yes :)