New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect parsing of latest version.json shows old version as latest #15745
Comments
|
@ibennetch our api does not indicate the right latest version |
|
https://www.phpmyadmin.net/home_page/version.json returns an array (if that's the proper way to refer to it in JSON) of currently supported versions: {
"date": "2019-12-26",
"version": "5.0.0",
"releases": [
{
"date": "2019-12-26",
"php_versions": ">=5.5,<8.0",
"version": "4.9.3",
"mysql_versions": ">=5.5"
},
{
"date": "2019-12-26",
"php_versions": ">=7.1,<8.0",
"version": "5.0.0",
"mysql_versions": ">=5.5"
}
]
}I think that the first/outer 'version' always points to the latest release, so we could first get the "current maximum version" from that before checking that the PHP and MySQL versions are compatible from deeper in the "releases" array. I'd prefer a solution that improves the parsing within phpMyAdmin rather than changing the versions.json file, because there are times we support more than one version. |
|
@ibennetch Are you suggesting that we should parse the JSON in such a way that it considers the highest version ? |
|
Yes, I think phpMyAdmin should look at the first version (which should be
the latest), then go through the list of versions to verify that the PHP
and MySQL versions are compatible.
|
|
Got it 👍 |
;)
The text was updated successfully, but these errors were encountered: