a view named 'views' adds an expand button

[williamdes]

PMA 5.0 and maybe before

create a view named views and use SELECT 1; as value

[williamdes]

Maybe related to #14698

[yashrajbothra]

Could you explain me little more?

[williamdes]

@yashrajbothra create a view named "views" the expand button should not exist

[yashrajbothra]

Thanks @williamdes I got the issue and started working on it 👍👍

[yashrajbothra]

when creating table named 'table' and click on expand icon it also give multiple errors

Like: Warning in .\libraries\classes\Navigation\NavigationTree.php#1178 vsprintf(): Too few arguments

#keyword error

[williamdes]

@yashrajbothra yes, this is an issue on master branch
If you want to fix it go ahead, but please fix #15733 on QA_5_0 ;)

[yashrajbothra]

hey @williamdes after debugging and tracing the code history. I got to know it happens 5e2023c
file: libraries/classes/Navigation/NavigationTree.php
line:810
because if node name itself is in sterile, then it allows it as Group and shows expand

If any suggestion plz suggest. I will try to propose solution tommorow.

[williamdes]

Hey @yashrajbothra
Why did you link the commit, I do not understand how it could have changed something 🤔

I will try to propose solution tomorrow.

Okay, I will wait then

[yashrajbothra]

Sorry, I refered to a Incorrect commit now i have changed that commit you can see now. (in_array($node->real_name, $sterile) this takes name of every node and if the sterile array contains that it becomes a group.

[williamdes]

Thank you, I understand better now
I will try to understand why the commit has introduced and see if your fix does not break that previous fix
You can also do that if you want :)

[yashrajbothra]

Okay. I will check on it👍

[yashrajbothra]

LGTM 👍.Because columns and indexes always have one children(New) it will not break any case.