Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected UI of action links #15780

Closed
yashrajbothra opened this issue Jan 12, 2020 · 13 comments
Closed

Unexpected UI of action links #15780

yashrajbothra opened this issue Jan 12, 2020 · 13 comments
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
Milestone

Comments

@yashrajbothra
Copy link
Contributor

Describe the bug

Some action links are not clearly visible

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Settings -> Main Panel -> Browse Mode'
  2. Change How to display various action links to Text
  3. Go To any Table Structure
  4. See error in Action Links

Expected behavior

AFAIK Action Links should be visible in blue

Screenshots

image

@williamdes
Copy link
Member

Version ?

@williamdes williamdes added the Bug A problem or regression with an existing feature label Jan 12, 2020
@williamdes williamdes added this to Needs triage in issues via automation Jan 12, 2020
@yashrajbothra
Copy link
Contributor Author

Version : 5.0.2-dev

@yashrajbothra
Copy link
Contributor Author

I would like to work on this issue.

@williamdes
Copy link
Member

@yashrajbothra I assigned it to you, let us know your progress :)

@yashrajbothra
Copy link
Contributor Author

Great I have started working on it👍

@williamdes williamdes added this to the 5.0.2 milestone Jan 12, 2020
@yashrajbothra
Copy link
Contributor Author

Should i use 5.0.2 as base?

and after changing branch do we always have to use npm install and composer install

@williamdes
Copy link
Member

williamdes commented Jan 12, 2020

Should i use 5.0.2 as base?

yes

I personally do use yarn that convinced my with its speed 🚀
And I run composer update on master branch and go back to QA_5_0 without any more command than just yarn or yarn run css-compile (slower to type ^^)

@yashrajbothra
Copy link
Contributor Author

Thanks😊

yashrajbothra added a commit to yashrajbothra/phpmyadmin that referenced this issue Jan 13, 2020
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
yashrajbothra added a commit to yashrajbothra/phpmyadmin that referenced this issue Jan 13, 2020
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@yashrajbothra
Copy link
Contributor Author

yashrajbothra commented Jan 13, 2020

Hey @williamdes

image

There is very less space between Links. Should i add more space to it?

@yashrajbothra
Copy link
Contributor Author

i mean like this ->

image

@williamdes
Copy link
Member

@yashrajbothra I did not have time to check but I would like that you restore the behavior 4.9 had ;)
(see demo server https://demo.phpmyadmin.net/QA_4_9/)

@yashrajbothra
Copy link
Contributor Author

@williamdes i checked in QA_4_9 and it looks like this ->

image

If it looks okay which IDTS is then i can open PR.

@williamdes
Copy link
Member

@yashrajbothra I would agree to add more spacing, you can open a PR if you want

yashrajbothra added a commit to yashrajbothra/phpmyadmin that referenced this issue Jan 13, 2020
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
yashrajbothra added a commit to yashrajbothra/phpmyadmin that referenced this issue Jan 14, 2020
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 14, 2020
williamdes pushed a commit to yashrajbothra/phpmyadmin that referenced this issue Jan 14, 2020
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
williamdes added a commit that referenced this issue Jan 15, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Needs triage to Closed Jan 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Development

No branches or pull requests

2 participants