You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
thesmallstar opened this issue
Jan 15, 2020
· 5 comments
Assignees
Labels
BugA problem or regression with an existing featurehas-prAn issue that has a pull request pending that may fix this issue. The pull request may be incomplete
@williamdes , the lock appears to be showing up at each change of event-hash, checkbox being one of them.
One of the possible solutions is to ignore all checkbox event, should I proceed?
It does make sense of doing it since a user won't want that popup if he only changed the states of checkboxes.
One of the possible solutions is to ignore all checkbox event, should I proceed?
It does make sense of doing it since a user won't want that popup if he only changed the states of checkboxes.
I agree, if no SQL request needs to be saved then the user should be able to exit without a confirmation
williamdes
added
the
has-pr
An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
label
Jan 22, 2020
williamdes
changed the title
Prompted for confirmation for abandoning change when not needed on run SQL Page
Prompted for confirmation for abandoning change when not needed on run SQL Page (checkboxes)
Jan 22, 2020
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
BugA problem or regression with an existing featurehas-prAn issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Describe the bug
we are Prompted for confirmation for abandoning change when not needed on run SQL Page.
To Reproduce
Steps to reproduce the behaviour:
Go to Run SQL page.

Type anything in bookmarks query

The lock on the page correctly appears.
Tick one of the checkBox

remove all text written in bookmarks query

The page now should have no changes registered.
an unwanted confirmation appears.
Expected behaviour
No confirmation should appear at this point since we made no change to the page.
I am using Version 5.1.0-dev
The text was updated successfully, but these errors were encountered: