Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompted for confirmation for abandoning change when not needed on run SQL Page (checkboxes) #15798

Closed
thesmallstar opened this issue Jan 15, 2020 · 5 comments
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
Milestone

Comments

@thesmallstar
Copy link
Contributor

Describe the bug

we are Prompted for confirmation for abandoning change when not needed on run SQL Page.

To Reproduce

Steps to reproduce the behaviour:

  1. Go to Run SQL page.
    image

  2. Type anything in bookmarks query
    image
    The lock on the page correctly appears.

  3. Tick one of the checkBox
    image

  4. remove all text written in bookmarks query
    image

The page now should have no changes registered.

  1. Move to another page
    image

an unwanted confirmation appears.

Expected behaviour

No confirmation should appear at this point since we made no change to the page.

I am using Version 5.1.0-dev

@williamdes williamdes added the Bug A problem or regression with an existing feature label Jan 15, 2020
@williamdes williamdes added this to Needs triage in issues via automation Jan 15, 2020
@williamdes
Copy link
Member

I assume this is an error also on 5.0.2-dev for anyone who wants to fix it please use QA_5_0 branch as base

@thesmallstar
Copy link
Contributor Author

I am working on this :)

@thesmallstar
Copy link
Contributor Author

@williamdes , the lock appears to be showing up at each change of event-hash, checkbox being one of them.
One of the possible solutions is to ignore all checkbox event, should I proceed?
It does make sense of doing it since a user won't want that popup if he only changed the states of checkboxes.

@williamdes
Copy link
Member

One of the possible solutions is to ignore all checkbox event, should I proceed?
It does make sense of doing it since a user won't want that popup if he only changed the states of checkboxes.

I agree, if no SQL request needs to be saved then the user should be able to exit without a confirmation

@thesmallstar
Copy link
Contributor Author

Okay :)

@williamdes williamdes self-assigned this Jan 22, 2020
@williamdes williamdes added this to the 5.0.2 milestone Jan 22, 2020
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 22, 2020
@williamdes williamdes changed the title Prompted for confirmation for abandoning change when not needed on run SQL Page Prompted for confirmation for abandoning change when not needed on run SQL Page (checkboxes) Jan 22, 2020
williamdes added a commit that referenced this issue Jan 22, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Needs triage to Closed Jan 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Development

No branches or pull requests

2 participants