Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected Modal Heading #15810

Closed
yashrajbothra opened this issue Jan 17, 2020 · 8 comments · Fixed by #15917
Closed

Unexpected Modal Heading #15810

yashrajbothra opened this issue Jan 17, 2020 · 8 comments · Fixed by #15917
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
Milestone
5.0.2

Comments

@yashrajbothra
Copy link
Contributor

Describe the bug

Unexpected code appearing on heading of modal

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Navigation Bar'
  2. Click on (+) 'Function || Procedure -> New'
  3. See error

Expected behavior

A heading like Add Routine Should appear on Modal

Screenshots

Unexpected
image

Expected
image

Configuration

  • phpMyAdmin version: 5.1.0-dev (master)
@ibennetch
Copy link
Member

Probably similar to #15119

@ibennetch ibennetch added good first issue ui Issues relating to the user interface labels Jan 18, 2020
@kartik1000
Copy link
Contributor

kartik1000 commented Jan 18, 2020 •
edited

This bug is not present till 4.8.4 🤔

@williamdes
Copy link
Member

Thank you for the research, If someone had time to do a git bisect between the first affected version ans the previous one then please post the results here

@yashrajbothra
Copy link
Contributor Author

git bisect result 6ed8035 as first bad commit

image

@williamdes
Copy link
Member

@OfficialOzioma can you have a look into this issue ?

You will probably have to revert a change made in 6ed8035

@williamdes williamdes added this to Triage zone in Enhancements Jan 23, 2020
@williamdes williamdes added the Bug A problem or regression with an existing feature label Jan 24, 2020
@williamdes williamdes added this to Needs triage in issues via automation Jan 24, 2020
@williamdes williamdes removed this from Triage zone in Enhancements Jan 24, 2020
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Jan 24, 2020
@rahgurung rahgurung mentioned this issue Feb 4, 2020
Merged
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Feb 4, 2020
@williamdes williamdes mentioned this issue Feb 8, 2020
Closed
@rabeehrz rabeehrz mentioned this issue Feb 15, 2020
Closed
@williamdes williamdes added this to the 5.0.2 milestone Feb 22, 2020
@williamdes williamdes self-assigned this Feb 22, 2020
williamdes pushed a commit to rahgurung/phpmyadmin that referenced this issue Feb 22, 2020
@rahgurung @williamdes
Fix phpmyadmin#15810 - the modal heading
ea35650 
Signed-off-by: Rahul Gurung <gurungrahul2@gmail.com>
@williamdes
Copy link
Member

The line was added by 50266d2 and can not be removed.
It will affect table renaming, navigation between tables, etc..

Git bisect is correct for 6ed8035 but this issue is a mix of multiple issues.

Back in the day, remove the "title" attribute on "new procedure" link and you will see the current issue.

williamdes added a commit that referenced this issue Feb 22, 2020
@williamdes
Merge #15917 - Fix #15810 - Unexpected Modal Heading
e296b59 
Pull-request: #15917
Fixes: #15810

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Feb 22, 2020
@williamdes
Add ChangeLog entry for #15810
37b7902 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Feb 22, 2020
@williamdes
Copy link
Member

Still present on all actions for individual Routines, etc..

Version: 5.0.3-dev

@Jay04653
Copy link

The same on User accounts -> Export popup on version 5.0.2.

@williamdes williamdes mentioned this issue Jul 13, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.0.2
Development

Successfully merging a pull request may close this issue.

fixed the modal heading rahgurung/phpmyadmin
5 participants
@ibennetch @Jay04653 @williamdes @kartik1000 @yashrajbothra