Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browse foreign values doesn't work with grid edit #15811

Closed
MauricioFauth opened this issue Jan 18, 2020 · 4 comments
Closed

Browse foreign values doesn't work with grid edit #15811

MauricioFauth opened this issue Jan 18, 2020 · 4 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
5.0.2

Comments

@MauricioFauth
Copy link
Member

Describe the bug

The Browse foreign values link doesn't work when editing relational values inline. It opens a new page instead of opening a modal.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Browse tab of the film_actor table of the sakila database.
  2. Double click on any actor_id or film_id values to enter in the grid edit mode.
  3. Click on Browse foreign values link.

Expected behavior

A modal should open.

Additional context

Affects QA_5_0 and master branches.
@MauricioFauth MauricioFauth added the Bug A problem or regression with an existing feature label Jan 18, 2020
@williamdes williamdes added this to Needs triage in issues via automation Jan 18, 2020
@williamdes williamdes moved this from Needs triage to Medium priority in issues Jan 18, 2020
@thesmallstar
Copy link
Contributor

Can I look into it?

@williamdes
Copy link
Member

Yes :)

@thesmallstar
Copy link
Contributor

@williamdes
I am getting a bad gateway error on the demo link, and also here:
image

am I missing anything?

@yashrajbothra
Copy link
Contributor

@thesmallstar ya,I also get that error sometimes but IDTS you are missing anything.

@rahgurung rahgurung mentioned this issue Jan 19, 2020
Merged
@williamdes williamdes self-assigned this Jan 19, 2020
@williamdes williamdes added this to the 5.0.2 milestone Jan 19, 2020
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 19, 2020
williamdes added a commit that referenced this issue Jan 19, 2020
@williamdes
Add ChangeLog entry for #15811
899a63d 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Medium priority to Closed Jan 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
5.0.2
Development

No branches or pull requests
4 participants
@MauricioFauth @williamdes @thesmallstar @yashrajbothra