Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] Table borders missing on theme original #15818

Closed
nunoperalta opened this issue Jan 19, 2020 · 2 comments
Closed

[regression] Table borders missing on theme original #15818

nunoperalta opened this issue Jan 19, 2020 · 2 comments
Assignees
Labels
Bug A problem or regression with an existing feature good first issue ui Issues relating to the user interface
Projects
Milestone

Comments

@nunoperalta
Copy link

Since phpMyAdmin 5.0.0, the classic theme lost the borders of the tables, making it a bit "ugly" to look at:

image

image

I have automated the following addition to CSS on phpMyAdmin upgrades:

.table_results tr, #tablestructure tr, #structureTable tr {
    border-bottom: 1px solid #aaa;
}

I'd like to suggest this as official CSS.

Looks like this (much better):

image

image

@williamdes williamdes added good first issue ui Issues relating to the user interface labels Jan 19, 2020
@williamdes williamdes added this to Needs triage in issues via automation Jan 19, 2020
@williamdes
Copy link
Member

@nunoperalta adding

table {
  border-collapse: separate;
}

Fixes the issue, do I commit that for next version ?

@williamdes williamdes added the Bug A problem or regression with an existing feature label Jan 19, 2020
@williamdes williamdes self-assigned this Jan 19, 2020
@williamdes williamdes added this to the 5.0.2 milestone Jan 19, 2020
@williamdes williamdes changed the title Table borders suggestion [regression] Table borders missing on theme original Jan 19, 2020
@nunoperalta
Copy link
Author

Ah yeah! That makes it look like before.
Yup - I'd go ahead with that!

williamdes added a commit that referenced this issue Jan 19, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Needs triage to Closed Jan 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature good first issue ui Issues relating to the user interface
Projects
issues
  
Closed
Development

No branches or pull requests

2 participants