Invalid behavior in convertBitDefaultValue (escape_mysql_wildcards) helper

[POPSuL]

Describe the bug

Page server_privileges have option list with list of databases. If database starts with b (like big) option value has ig, but title seems correct.

To Reproduce

Steps to reproduce the behavior:

1. Create database like big_database
2. User accounts, select any user that click Database tab
3. Select big_database in Add privileges on the following database(s): options list and click Go
4. See "Edit privileges: User account 'pma'@'192.168.30.%' - Databases ig_database" in page title
5. Than try to select any role and click Go, than you will see query like GRANT SELECT, INSERT, UPDATE, DELETE ON ig_database.* TO 'pma'@'192.168.30.%';

Expected behavior

Database should be big_database

Screenshots

Server configuration

Demo page from https://demo.phpmyadmin.net/

Client configuration

Chrome 79, Ubuntu linux

[CoreyBuckley]

Hi, I'm interested in working on this issue. Is that okay? 🙂

[williamdes]

hello @CoreyBuckley
You can work on this one, please use QA_5_0 as base branch and target for your PR

[POPSuL]

Maybe write tests for that?

[CoreyBuckley]

I'm not sure how to do that 😅

I can see that there is a function for testing convertBitDefaultValue already in test/classes/UtilTest.php, but I'm not sure where I would add the actual test case..

[CoreyBuckley]

I noticed in the log from Travis that for the test I'm failing it uses the input b' and expects this to become the empty string.

In Util.php convertBitDefaultValue has the comment

/*
Converts a BIT type default value
     * for example, b'010' becomes 010
*/

Should there also be an example in the comment like:

/*
Converts a BIT type default value
     * for example, b'010' becomes 010
     * or, "b'01" becomes "01"
*/

?

[williamdes]

I'm not sure how to do that

I will add comments on the PR to help you