Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError when submitting unchanged data #15833

Closed
craue opened this issue Jan 22, 2020 · 2 comments
Closed

TypeError when submitting unchanged data #15833

craue opened this issue Jan 22, 2020 · 2 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Projects
Milestone

Comments

@craue
Copy link

craue commented Jan 22, 2020

Describe the bug

PHP Fatal error: Uncaught TypeError: Argument 5 passed to PhpMyAdmin\Sql::getQueryResponseForResultsReturned() must be of the type string or null, object given, called in /var/opt/phpmyadmin/5.0.1/libraries/classes/Sql.php on line 2271 and defined in /var/opt/phpmyadmin/5.0.1/libraries/classes/Sql.php:1816

Steps to reproduce the behavior

  1. CREATE TABLE `menu` (`id` INT NOT NULL , `name` VARCHAR(100) NOT NULL, PRIMARY KEY (`id`));
  2. INSERT INTO `menu` (`id`, `name`) VALUES ('1', 'whatever');
  3. click action "Browse" for the "menu" table
  4. click "Edit" in the row to edit it on a new page (not inline)
  5. click "Go" without changing the data
  6. 💥

If you change any data before clicking "Go", everything works as expected.

Server configuration

  • Debian 10.2
  • Apache 2.4.38-3+deb10u3
  • MariaDB 10.3.18-MariaDB-0+deb10u1
  • PHP 7.3.11-1~deb10u1
  • phpMyAdmin 5.0.1
@williamdes williamdes added the Bug A problem or regression with an existing feature label Jan 22, 2020
@williamdes williamdes added this to Needs triage in issues via automation Jan 22, 2020
@williamdes williamdes self-assigned this Jan 22, 2020
@williamdes williamdes added this to the 5.0.2 milestone Jan 22, 2020
@williamdes
Copy link
Member

Thank you for the report and precise steps !

williamdes added a commit that referenced this issue Jan 22, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Needs triage to Closed Jan 22, 2020
@craue
Copy link
Author

craue commented Jan 22, 2020

Confirmed as fixed. That was quick, @williamdes. Thanks.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Development

No branches or pull requests

2 participants