Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer full screen issues (Menu item toggling and black borders) #15854

Closed
rabeehrz opened this issue Jan 26, 2020 · 4 comments
Closed

Designer full screen issues (Menu item toggling and black borders) #15854

rabeehrz opened this issue Jan 26, 2020 · 4 comments
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted ui Issues relating to the user interface
Milestone

Comments

@rabeehrz
Copy link
Contributor

Describe the bug

When switching to fullscreen on the designer,

  • Black borders appears on the canvas and the canvas resizes when moving tables around.
  • Pressing ESC key to exit full screen in the Designer messes up the menu toggle buttons.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Designer
  2. Click on View Fullscreen in the menu
  3. You can see the black borders. Move the table into the black screen and the white canvas resizes.
  4. Press ESC Key to exit full screen
  5. The menu item for toggle fullscreen is not toggled correctly.

Expected behavior

  • Full screen white canvas.
  • Proper icon toggling on exiting full screen by pressing ESC Key

Server configuration

  • Operating system: phpMyAdmin demo - MySQL (192.168.30.23 via TCP/IP
  • Web server: nginx/1.10.3
  • Database version: 8.0.18 - MySQL Community Server - GP
  • PHP version: 7.4.0
  • phpMyAdmin version: 5.0.1

Client configuration

  • Browser: Google Chrome
  • Operating system: macOS Catalina 10.15.2
@rabeehrz
Copy link
Contributor Author

I would like to work on this issue as well!

@williamdes williamdes added this to Needs triage in issues via automation Jan 26, 2020
@williamdes williamdes added this to To Do in Designer Jan 26, 2020
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Jan 26, 2020
@williamdes williamdes added Bug A problem or regression with an existing feature help wanted ui Issues relating to the user interface labels Jan 26, 2020
@williamdes
Copy link
Member

@rabeehrz I agree, I had that issue too much ^^
Thank you for opening an issue about it

@rabeehrz
Copy link
Contributor Author

@williamdes I can work on this right? What should I use as base?

@williamdes
Copy link
Member

williamdes commented Jan 26, 2020

@williamdes I can work on this right?

yes you can, I will be very glad to see this issue fixed !

What should I use as base?

Please use QA_5_0

In general for branches:
QA_4_9 > security fixes
QA_5_0 > bug fixes
master > features or other things

@williamdes williamdes self-assigned this Jan 26, 2020
@williamdes williamdes added this to the 5.0.2 milestone Jan 26, 2020
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 26, 2020
@williamdes williamdes moved this from To Do to In Progress in Designer Jan 28, 2020
williamdes added a commit that referenced this issue Jan 28, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Jan 28, 2020
@williamdes williamdes moved this from In Progress to Done in Designer May 3, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted ui Issues relating to the user interface
Projects
issues
  
Closed
Development

No branches or pull requests

2 participants